Skip to contentSkip to conversation

efi_loader: Do not expose HII protocols yet

PATCH Superseded Alexander Graf 1 participant 1 message Feb 11, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi_loader: Do not expose HII protocols yet

Heinrich ran into issues with HII and iPXE which lead to #SErrors on his Odroid-C2 system. We definitely do not want to regress just yet, so let's not expose the HII protocols just yet.

Once someone figures out, why this breaks iPXE (probably a NULL dereference), we can revert this patch again.

---
 lib/efi_loader/efi_boottime.c | 18 ------------------
 1 file changed, 18 deletions(-)
lib/efi_loader/efi_boottime.c +0 -18
index fc26d6adc1..dbf0d56c1d 100644
@@ -1558,24 +1558,6 @@ efi_status_t efi_setup_loaded_image(struct efi_device_path *device_path,
 	if (ret != EFI_SUCCESS)
 		goto failure;
 
-	ret = efi_add_protocol(&obj->header,
-			       &efi_guid_hii_string_protocol,
-			       (void *)&efi_hii_string);
-	if (ret != EFI_SUCCESS)
-		goto failure;
-
-	ret = efi_add_protocol(&obj->header,
-			       &efi_guid_hii_database_protocol,
-			       (void *)&efi_hii_database);
-	if (ret != EFI_SUCCESS)
-		goto failure;
-
-	ret = efi_add_protocol(&obj->header,
-			       &efi_guid_hii_config_routing_protocol,
-			       (void *)&efi_hii_config_routing);
-	if (ret != EFI_SUCCESS)
-		goto failure;
-
 	return ret;
 failure:
 	printf("ERROR: Failure to install protocols for loaded image\n");
Signature · 1 line
2.12.3