rapidio/mport_cdev: mark expected switch fall-through
PATCH 1/1 rapidio/mport_cdev: mark expected switch fall-through
n preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/rapidio/devices/rio_mport_cdev.c: In function ‘mport_release_mapping’:drivers/rapidio/devices/rio_mport_cdev.c:2151:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
rio_unmap_inb_region(mport, map->phys_addr);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CC drivers/regulator/fixed-helper.o
CC drivers/pinctrl/stm32/pinctrl-stm32f429.odrivers/rapidio/devices/rio_mport_cdev.c:2152:2: note: here
case MAP_DMA:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/rapidio/devices/rio_mport_cdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/rapidio/devices/rio_mport_cdev.c +1 -0
@@ -2149,6 +2149,7 @@ static void mport_release_mapping(struct kref *ref)switch (map->dir) {case MAP_INBOUND :rio_unmap_inb_region (mport, map->phys_addr); +/* fall through */ case MAP_DMA :dma_free_coherent (mport->dev.parent, map->size, map->virt_addr, map->phys_addr);
Signature · 1 line
2.20.1
Hi all,
Friendly ping:
Who can review or take this, please?
Thanks
--
Gustavo
Quoted 38 lines · Gustavo A. R. Silva
n preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/rapidio/devices/rio_mport_cdev.c: In function ‘mport_release_mapping’:drivers/rapidio/devices/rio_mport_cdev.c:2151:3: warning: this statement may fall through [-Wimplicit-fallthrough=]rio_unmap_inb_region(mport, map->phys_addr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~CC
drivers/regulator/fixed-helper.o
CCdrivers/pinctrl/stm32/pinctrl-stm32f429.odrivers/rapidio/devices/rio_mport_cdev.c:2152:2: note: here
caseMAP_DMA:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/rapidio/devices/rio_mport_cdev.c | 1 + 1 file changed, 1 insertion(+)drivers/rapidio/devices/rio_mport_cdev.c +1
-0@@ -2149,6 +2149,7 @@ static void mport_release_mapping(struct kref *ref)switch (map->dir) {case MAP_INBOUND :rio_unmap_inb_region (mport, map->phys_addr); +/* fall through */ case MAP_DMA :dma_free_coherent (mport->dev.parent, map->size, map->virt_addr, map->phys_addr);