Skip to contentSkip to conversation

Fix error message when xfs handle library not found

PATCH In review [email protected] 3 participants 5 messages Feb 12, 2019 – Feb 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix error message when xfs handle library not found

From: Filipe Manana <[email protected]>

The error message mentions a "make install-lib" target from xfsprogs, however that target does not exists in xfsprogs, what exists is a target named "install-dev". So fix that and replace "install-lib" with "install-dev".

---
 m4/package_xfslibs.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
m4/package_xfslibs.m4 +1 -1
index 9be56e11..ad019518 100644
@@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
         echo
         echo 'FATAL ERROR: could not find a current XFS handle library.'
         echo 'Install or upgrade the XFS library package.'
-        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
+        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'
         exit 1
     ])
     libhdl="-lhandle"
Signature · 1 line
2.11.0
#1 lore raw
Quoted 17 lines · On 2/12/19 12:18 PM, [email protected] wrote:

From: Filipe Manana <[email protected]>

The error message mentions a "make install-lib" target from xfsprogs, however that target does not exists in xfsprogs, what exists is a target named "install-dev". So fix that and replace "install-lib" with "install-dev".

---
 m4/package_xfslibs.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
m4/package_xfslibs.m4 +0 -0
index 9be56e11..ad019518 100644

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 85

Quoted 3 lines
m4/package_xfslibs.m4 +0 -0
@@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
         echo
         echo 'FATAL ERROR: could not find a current XFS handle library.'
         echo 'Install or upgrade the XFS library package.'

To fix things up a bit more, I'd probably not refer to the "XFS library package" because I'm not sure that exists anywhere either, does it?

In fedora/rhel land, it's in xfsprogs & xfsprogs-devel for development.

Not sure about suse or debian or ...?

Not a huge deal but if nobody ships xfsprogs-libs (or similar) then maybe best to fix that line as well.

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 86

Quoted 2 lines
m4/package_xfslibs.m4 +1 -1
-        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
+        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'

and yeah, this part makes sense.

-Eric

Quoted 4 lines
m4/package_xfslibs.m4 +0 -0
         exit 1
     ])
     libhdl="-lhandle"
#2 lore raw

[cc [email protected]]

Quoted 25 lines · Eric Sandeen
Quoted 17 lines · On 2/12/19 12:18 PM, [email protected] wrote:

From: Filipe Manana <[email protected]>

The error message mentions a "make install-lib" target from xfsprogs, however that target does not exists in xfsprogs, what exists is a target named "install-dev". So fix that and replace "install-lib" with "install-dev".

---
 m4/package_xfslibs.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
m4/package_xfslibs.m4 +0 -0
index 9be56e11..ad019518 100644

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 85

Quoted 3 lines
m4/package_xfslibs.m4 +0 -0
@@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
         echo
         echo 'FATAL ERROR: could not find a current XFS handle library.'
         echo 'Install or upgrade the XFS library package.'

To fix things up a bit more, I'd probably not refer to the "XFS library package" because I'm not sure that exists anywhere either, does it?

Quoted 3 lines

In fedora/rhel land, it's in xfsprogs & xfsprogs-devel for development.

Not sure about suse or debian or ...?

Debian:

$ apt-file search libhandle
....
xfslibs-dev: /lib/libhandle.a
xfslibs-dev: /lib/libhandle.so
xfslibs-dev: /usr/lib/libhandle.a
xfslibs-dev: /usr/lib/libhandle.la
xfsprogs: /lib/libhandle.so.1
xfsprogs: /lib/libhandle.so.1.0.3
$

So the libhandle library DSO is shipped in xfsprogs. The /static/ library is shipped in xfslibs-dev.

So what is fstests requiring here - the DSO or the static library? If it's the static library, then why does it need that and why can't it use the DSO shipped as part of the main xfsprogs package?

Quoted 7 lines

Not a huge deal but if nobody ships xfsprogs-libs (or similar) then maybe best to fix that line as well.

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 86

Quoted 2 lines
m4/package_xfslibs.m4 +1 -1
-        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
+        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'

and yeah, this part makes sense.

Only if it requires the static libhandle.a library.

But that said, we should probably get rid of the static library and just ship the DSO - I can't think of a good reason for shipping a static version of a DSO in a "dev" package these days.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#3 lore raw
Quoted 44 lines · Dave Chinner

[cc [email protected]]

Quoted 25 lines · Eric Sandeen
Quoted 17 lines · On 2/12/19 12:18 PM, [email protected] wrote:

From: Filipe Manana <[email protected]>

The error message mentions a "make install-lib" target from xfsprogs, however that target does not exists in xfsprogs, what exists is a target named "install-dev". So fix that and replace "install-lib" with "install-dev".

---
 m4/package_xfslibs.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
m4/package_xfslibs.m4 +0 -0
index 9be56e11..ad019518 100644

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 85

Quoted 3 lines
m4/package_xfslibs.m4 +0 -0
@@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
         echo
         echo 'FATAL ERROR: could not find a current XFS handle library.'
         echo 'Install or upgrade the XFS library package.'

To fix things up a bit more, I'd probably not refer to the "XFS library package" because I'm not sure that exists anywhere either, does it?

Quoted 3 lines

In fedora/rhel land, it's in xfsprogs & xfsprogs-devel for development.

Not sure about suse or debian or ...?

Debian:

$ apt-file search libhandle
....
xfslibs-dev: /lib/libhandle.a
xfslibs-dev: /lib/libhandle.so
xfslibs-dev: /usr/lib/libhandle.a
xfslibs-dev: /usr/lib/libhandle.la
xfsprogs: /lib/libhandle.so.1
xfsprogs: /lib/libhandle.so.1.0.3
$
Quoted 6 lines

So the libhandle library DSO is shipped in xfsprogs. The /static/ library is shipped in xfslibs-dev.

So what is fstests requiring here - the DSO or the static library? If it's the static library, then why does it need that and why can't it use the DSO shipped as part of the main xfsprogs package?

I don't think it's looking for libhandle.a, I certainly don't have that available on my test systems...

Quoted 9 lines
Quoted 7 lines

Not a huge deal but if nobody ships xfsprogs-libs (or similar) then maybe best to fix that line as well.

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 86

Quoted 2 lines
m4/package_xfslibs.m4 +1 -1
-        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
+        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'

and yeah, this part makes sense.

Only if it requires the static libhandle.a library.

Oh, ok. And it doesn't.

so, it should be:

echo 'FATAL ERROR: could not find a current XFS handle library.' echo 'Install or upgrade the xfsprogs package.'
echo 'Alternatively, run "make install" from the xfsprogs source.'

?

(if I have headers from xfsprogs-devel, but no xfsprogs installed, I hit the above error first on the missing libhandle)

-Eric

#4 lore raw
Quoted 67 lines · Eric Sandeen
Quoted 44 lines · Dave Chinner

[cc [email protected]]

Quoted 25 lines · Eric Sandeen
Quoted 17 lines · On 2/12/19 12:18 PM, [email protected] wrote:

From: Filipe Manana <[email protected]>

The error message mentions a "make install-lib" target from xfsprogs, however that target does not exists in xfsprogs, what exists is a target named "install-dev". So fix that and replace "install-lib" with "install-dev".

---
 m4/package_xfslibs.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
m4/package_xfslibs.m4 +0 -0
index 9be56e11..ad019518 100644

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 85

Quoted 3 lines
m4/package_xfslibs.m4 +0 -0
@@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
         echo
         echo 'FATAL ERROR: could not find a current XFS handle library.'
         echo 'Install or upgrade the XFS library package.'

To fix things up a bit more, I'd probably not refer to the "XFS library package" because I'm not sure that exists anywhere either, does it?

Quoted 3 lines

In fedora/rhel land, it's in xfsprogs & xfsprogs-devel for development.

Not sure about suse or debian or ...?

Debian:

$ apt-file search libhandle
....
xfslibs-dev: /lib/libhandle.a
xfslibs-dev: /lib/libhandle.so
xfslibs-dev: /usr/lib/libhandle.a
xfslibs-dev: /usr/lib/libhandle.la
xfsprogs: /lib/libhandle.so.1
xfsprogs: /lib/libhandle.so.1.0.3
$
Quoted 6 lines

So the libhandle library DSO is shipped in xfsprogs. The /static/ library is shipped in xfslibs-dev.

So what is fstests requiring here - the DSO or the static library? If it's the static library, then why does it need that and why can't it use the DSO shipped as part of the main xfsprogs package?

I don't think it's looking for libhandle.a, I certainly don't have that available on my test systems...

Quoted 9 lines
Quoted 7 lines

Not a huge deal but if nobody ships xfsprogs-libs (or similar) then maybe best to fix that line as well.

m4/package_xfslibs.m4 AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE], · line 86

Quoted 2 lines
m4/package_xfslibs.m4 +1 -1
-        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
+        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'

and yeah, this part makes sense.

Only if it requires the static libhandle.a library.

Oh, ok. And it doesn't.

Quoted 7 lines

so, it should be:

echo 'FATAL ERROR: could not find a current XFS handle library.' echo 'Install or upgrade the xfsprogs package.'
echo 'Alternatively, run "make install" from the xfsprogs source.'

?

Sounds good to me.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]