audit: mark expected switch fall-through
PATCH 1/1 audit: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/auditfilter.c: In function ‘audit_krule_to_data’:kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) {
^kernel/auditfilter.c:674:3: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- kernel/auditfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/auditfilter.c +1 -1
@@ -670,7 +670,7 @@ static struct audit_rule_data *audit_krule_to_data(struct audit_krule *krule) data->values[i] =AUDIT_UID_UNSET ;break ; } -/* fallthrough if set */ +/* fall through - if set */ default : data->values[i] = f->val; }
Signature · 1 line
2.20.1
Quoted 18 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/auditfilter.c: In function ‘audit_krule_to_data’:kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) { ^ kernel/auditfilter.c:674:3: note: here default: ^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Quoted 7 lines
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- kernel/auditfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Merged into audit/next, thanks.
Signature · 2 lines
paul moore www.paul-moore.com
Quoted 23 lines · Paul Moore
Quoted 21 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/auditfilter.c: In function ‘audit_krule_to_data’:kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) { ^ kernel/auditfilter.c:674:3: note: here default: ^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- kernel/auditfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Merged into audit/next, thanks.
Thanks, Paul.
--
Gustavo
Quoted 23 lines · Paul Moore
Quoted 21 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/auditfilter.c: In function ‘audit_krule_to_data’:kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wimplicit-fallthrough=]if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) { ^ kernel/auditfilter.c:674:3: note: here default: ^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- kernel/auditfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Merged into audit/next, thanks.
Thanks, Paul.
--
Gustavo