blktrace: mark expected switch fall-through
Subsystems (2)
PATCH 1/1 blktrace: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/trace/blktrace.c: In function ‘blk_trace_ioctl’:kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
start = 1;
~~~~~~^~~kernel/trace/blktrace.c:726:2: note: here
case BLKTRACESTOP:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- kernel/trace/blktrace.c | 1 + 1 file changed, 1 insertion(+)
kernel/trace/blktrace.c +1 -0
@@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)#endif case BLKTRACESTART : start =1 ; +/* fall through */ case BLKTRACESTOP : ret =__blk_trace_startstop (q, start);break ;
Signature · 1 line
2.20.1
Quoted 9 lines · On Tue, 12 Feb 2019 15:03:11 -0600 "Gustavo A. R. Silva"…
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/trace/blktrace.c: In function ‘blk_trace_ioctl’:kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]start = 1; ~~~~~~^~~
Quoted 9 lines
kernel/trace/blktrace.c:726:2: note: here
case BLKTRACESTOP:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
-- Steve
Quoted 17 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- kernel/trace/blktrace.c | 1 + 1 file changed, 1 insertion(+)kernel/trace/blktrace.c +1
-0@@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)#endif case BLKTRACESTART : start =1 ; +/* fall through */ case BLKTRACESTOP : ret =__blk_trace_startstop (q, start);break ;