tracing/probes: Mark expected switch fall-through
PATCH 1/1 tracing/probes: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
arg++; /* Skip '+', because kstrtol() rejects it. */
~~~^~kernel/trace/trace_probe.c:303:2: note: here
case '-':
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- kernel/trace/trace_probe.c | 1 + 1 file changed, 1 insertion(+)
kernel/trace/trace_probe.c +1 -0
@@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,case '+' :/* deref memory */ arg++;/* Skip '+', because kstrtol() rejects it. */ +/* fall through */ case '-' : tmp =strchr (arg,'(' );if (!tmp)
Signature · 1 line
2.20.1
Steven Rostedt
maintainerQuoted 5 lines · On Tue, 12 Feb 2019 15:10:40 -0600 "Gustavo A. R. Silva"…
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
Quoted 7 lines
kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
arg++; /* Skip '+', becausekstrtol()rejects it. */
~~~^~kernel/trace/trace_probe.c:303:2: note: here
case '-':
^~~~
I also already applied this patch (still need to run through tests)
http://lkml.kernel.org/r/[email protected]
-- Steve
Quoted 23 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- kernel/trace/trace_probe.c | 1 + 1 file changed, 1 insertion(+)kernel/trace/trace_probe.c +1
-0@@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,case '+' :/* deref memory */ arg++;/* Skip '+', because kstrtol() rejects it. */ +/* fall through */ case '-' : tmp =strchr (arg,'(' );if (!tmp)
Quoted 16 lines · Steven Rostedt
Quoted 5 lines · On Tue, 12 Feb 2019 15:10:40 -0600 "Gustavo A. R. Silva"…
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
Quoted 7 lines
kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
arg++; /* Skip '+', becausekstrtol()rejects it. */
~~~^~kernel/trace/trace_probe.c:303:2: note: here
case '-':
^~~~
Quoted 4 lines
I also already applied this patch (still need to run through tests)
Oh, that's great. :)
Thanks
--
Gustavo