memstick: mark expected switch fall-throughs
Subsystems (2)
PATCH 1/1 memstick: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~drivers/memstick/host/jmb38x_ms.c:262:2: note: here
case 2:
^~~~drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~drivers/memstick/host/jmb38x_ms.c:265:2: note: here
case 1:
^~~~drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~drivers/memstick/host/tifm_ms.c:169:2: note: here
case 2:
^~~~drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
host->io_pos++;
~~~~~~~~~~~~^~drivers/memstick/host/tifm_ms.c:172:2: note: here
case 1:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/memstick/host/jmb38x_ms.c | 2 ++ drivers/memstick/host/tifm_ms.c | 2 ++ 2 files changed, 4 insertions(+)
drivers/memstick/host/jmb38x_ms.c +2 -0
@@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,case 3 : host->io_word[0 ] |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word[0 ] |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word[0 ] |= buf[off]; host->io_pos++;
drivers/memstick/host/tifm_ms.c +2 -0
@@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,case 3 : host->io_word |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word |= buf[off]; host->io_pos++;
Signature · 1 line
2.20.1
Hi,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
Quoted 76 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:262:2: note: here
case 2:
^~~~drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:265:2: note: here
case 1:
^~~~drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:169:2: note: here
case 2:
^~~~drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:172:2: note: here
case 1:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/memstick/host/jmb38x_ms.c | 2 ++ drivers/memstick/host/tifm_ms.c | 2 ++ 2 files changed, 4 insertions(+)drivers/memstick/host/jmb38x_ms.c +2
-0@@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,case 3 : host->io_word[0 ] |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word[0 ] |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word[0 ] |= buf[off]; host->io_pos++;drivers/memstick/host/tifm_ms.c +2
-0@@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,case 3 : host->io_word |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word |= buf[off]; host->io_pos++;
Hi all,
If no one cares, I'll add this to my tree for 5.2.
Thanks
--
Gustavo
Quoted 87 lines · Gustavo A. R. Silva
Hi,
Friendly ping:
Who can take this?
Thanks
--
GustavoQuoted 76 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:262:2: note: here
case 2:
^~~~drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:265:2: note: here
case 1:
^~~~drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:169:2: note: here
case 2:
^~~~drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:172:2: note: here
case 1:
^~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/memstick/host/jmb38x_ms.c | 2 ++ drivers/memstick/host/tifm_ms.c | 2 ++ 2 files changed, 4 insertions(+)drivers/memstick/host/jmb38x_ms.c +2
-0@@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,case 3 : host->io_word[0 ] |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word[0 ] |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word[0 ] |= buf[off]; host->io_pos++;drivers/memstick/host/tifm_ms.c +2
-0@@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,case 3 : host->io_word |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word |= buf[off]; host->io_pos++;
Quoted 33 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:262:2: note: here
case 2:
^~~~drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:265:2: note: here
case 1:
^~~~drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:169:2: note: here
case 2:
^~~~drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:172:2: note: here
case 1:
^~~~
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 40 lines
--- drivers/memstick/host/jmb38x_ms.c | 2 ++ drivers/memstick/host/tifm_ms.c | 2 ++ 2 files changed, 4 insertions(+)drivers/memstick/host/jmb38x_ms.c +2
-0@@ -259,9 +259,11 @@ static unsigned int jmb38x_ms_write_data(struct jmb38x_ms_host *host,case 3 : host->io_word[0 ] |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word[0 ] |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word[0 ] |= buf[off]; host->io_pos++;drivers/memstick/host/tifm_ms.c +2
-1@@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,case 3 : host->io_word |= buf[off +2 ] <<16 ; host->io_pos++; +/* fall through */ case 2 : host->io_word |= buf[off +1 ] <<8 ; host->io_pos++; +/* fall through */ case 1 : host->io_word |= buf[off]; host->io_pos++; --2.20.1
Signature · 1 line
Kees Cook
Quoted 35 lines · Kees Cook
Quoted 33 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:262:2: note: here
case 2:
^~~~drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/jmb38x_ms.c:265:2: note: here
case 1:
^~~~drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:169:2: note: here
case 2:
^~~~drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]host->io_pos++; ~~~~~~~~~~~~^~
drivers/memstick/host/tifm_ms.c:172:2: note: here
case 1:
^~~~
Quoted 9 lines
Quoted 6 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Kees Cook <[email protected]>
Thanks, Kees!
--
Gustavo