mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit
PATCH 2/2 mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit
Before printk.h was introduced and MTDDEBUG was removed, pr_crit() was calling MTDDEBUG(), which was since then replaced by the current pr_debug().
pr_debug is more appropriate here.
--- drivers/mtd/ubi/debug.h | 2 +- fs/ubifs/debug.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/mtd/ubi/debug.h +1 -1
@@ -29,7 +29,7 @@ void ubi_dump_vid_hdr(const struct ubi_vid_hdr *vid_hdr);#else #define ubi_assert (expr) do { \ if (unlikely(!(expr))) { \ - pr_crit("UBI assert failed in %s at %u\n", \ + pr_debug("UBI assert failed in %s at %u\n", \ __func__, __LINE__); \ dump_stack(); \ } \
fs/ubifs/debug.h +2 -2
@@ -167,7 +167,7 @@ struct ubifs_global_debug_info {#else #define ubifs_assert (expr) do { \ if (unlikely(!(expr))) { \ - pr_crit("UBIFS assert failed in %s at %u\n", \ + pr_debug("UBIFS assert failed in %s at %u\n", \ __func__, __LINE__); \ dump_stack(); \ } \
@@ -176,7 +176,7 @@ struct ubifs_global_debug_info {#define ubifs_assert_cmt_locked (c) do { \ if (unlikely(down_write_trylock(&(c)->commit_sem))) { \ up_write(&(c)->commit_sem); \ - pr_crit("commit lock is not locked!\n"); \ + pr_debug("commit lock is not locked!\n"); \ ubifs_assert(0); \ } \ } while (0)
Signature · 1 line
1.9.1
PATCH 2/2 mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit
Hello Eran,
Am 13.02.2019 um 19:56 schrieb Eran Matityahu:
Quoted 11 lines
Before
printk.hwas introduced and MTDDEBUG was removed,pr_crit()was callingMTDDEBUG(), which was since then replaced by the currentpr_debug().
pr_debugis more appropriate here.Signed-off-by Eran Matityahu <[email protected]>--- drivers/mtd/ubi/debug.h | 2 +- fs/ubifs/debug.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
queued for next merge window.
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
PATCH 2/2 mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit
In reply to Eran MatityahuHello Eran,
Am 13.02.2019 um 19:56 schrieb Eran Matityahu:
Quoted 11 lines
Before
printk.hwas introduced and MTDDEBUG was removed,pr_crit()was callingMTDDEBUG(), which was since then replaced by the currentpr_debug().
pr_debugis more appropriate here.Signed-off-by Eran Matityahu <[email protected]>--- drivers/mtd/ubi/debug.h | 2 +- fs/ubifs/debug.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to uboot-ubi.git master
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de