NFC: pn533: mark expected switch fall-throughs
PATCH 1/1 NFC: pn533: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
^drivers/nfc/pn533/pn533.c:2150:2: note: here
default:
^~~~~~~drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
^drivers/nfc/pn533/pn533.c:2276:2: note: here
default:
^~~~~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Addresses-Coverity-ID: 1230487 ("Missing break in switch")
Addresses-Coverity-ID: 1230488 ("Missing break in switch")
--- drivers/nfc/pn533/pn533.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/nfc/pn533/pn533.c +2 -0
@@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,break ; } +/* fall through */ default :/* jumbo frame ? */ if (skb->len >PN533_CMD_DATAEXCH_DATA_MAXLEN ) {
@@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)break ; } +/* fall through */ default :skb_put_u8 (skb,1 );/*TG*/
Signature · 1 line
2.20.1
Hi all,
If no one cares, I'll add this to my tree for 5.2
Thanks
--
Gustavo
Quoted 53 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (dev->tgt_active_prot == NFC_PROTO_FELICA) { ^
drivers/nfc/pn533/pn533.c:2150:2: note: here
default:
^~~~~~~drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (dev->tgt_active_prot == NFC_PROTO_FELICA) { ^
drivers/nfc/pn533/pn533.c:2276:2: note: here
default:
^~~~~~~Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Addresses-Coverity-ID: 1230487 ("Missing break in switch")
Addresses-Coverity-ID: 1230488 ("Missing break in switch")Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/nfc/pn533/pn533.c | 2 ++ 1 file changed, 2 insertions(+)drivers/nfc/pn533/pn533.c +2
-0@@ -2147,6 +2147,7 @@ static int pn533_transceive(struct nfc_dev *nfc_dev,break ; } +/* fall through */ default :/* jumbo frame ? */ if (skb->len >PN533_CMD_DATAEXCH_DATA_MAXLEN ) {@@ -2273,6 +2274,7 @@ static void pn533_wq_mi_recv(struct work_struct *work)break ; } +/* fall through */ default :skb_put_u8 (skb,1 );/*TG*/
Quoted 21 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warnings:
drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (dev->tgt_active_prot == NFC_PROTO_FELICA) { ^
drivers/nfc/pn533/pn533.c:2150:2: note: here
default:
^~~~~~~drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]if (dev->tgt_active_prot == NFC_PROTO_FELICA) { ^
drivers/nfc/pn533/pn533.c:2276:2: note: here
default:
^~~~~~~
Quoted 8 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Addresses-Coverity-ID: 1230487 ("Missing break in switch")
Addresses-Coverity-ID: 1230488 ("Missing break in switch")Signed-off-by Gustavo A. R. Silva <[email protected]>
Signature · 1 line
Kees Cook