binder: fix sparse issue in binder_alloc_selftest.c
Todd Kjos
maintainerPATCH 1/1 binder: fix sparse issue in binder_alloc_selftest.c
Fixes sparse issues reported by the kbuild test robot running on https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
char-misc-testing: bde4a19fc04f5 ("binder: use userspace pointer as base of buffer space")
Error output (drivers/android/binder_alloc_selftest.c):
sparse: warning: incorrect type in assignment (different address spaces) sparse: expected void *page_addr sparse: got void [noderef] <asn:1> *user_data sparse: error: subtraction of different types can't work
Fixed by adding necessary "__user" tags.
Reported-by kbuild test robot <[email protected]>
Signed-off-by Todd Kjos <[email protected]>
--- drivers/android/binder_alloc_selftest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/android/binder_alloc_selftest.c +3 -2
@@ -102,10 +102,11 @@ static bool check_buffer_pages_allocated(struct binder_alloc *alloc,struct binder_buffer *buffer, size_t size) { - void *page_addr, *end; + void __user *page_addr; +void __user *end;int page_index; - end = (void *)PAGE_ALIGN ((uintptr_t )buffer->user_data + size); + end = (void __user *)PAGE_ALIGN ((uintptr_t )buffer->user_data + size); page_addr = buffer->user_data;for (; page_addr < end; page_addr +=PAGE_SIZE ) { page_index = (page_addr - alloc->buffer) /PAGE_SIZE ;
Signature · 1 line
2.20.1.791.gb4d0f1c61a-goog