mx6ul_14x14_evk: Simplify the PMIC register writes
PATCH v2 1/1 mx6ul_14x14_evk: Simplify the PMIC register writes
There is no need to store the values written to the PMIC inside the 'reg' variable. Make it simpler by writing the values directly.
---
Changes since v1:
- Remove 1/2 notation, since this is a standalome patch
- Add Peng Fan on Cc
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +3 -6
@@ -86,16 +86,13 @@ int power_init_board(void)pmic_reg_write (dev,PFUZE3000_LDOGCTL , reg);/* SW1B step ramp up time from 2us to 4us/25mV */ - reg =0x40 ; -pmic_reg_write (dev,PFUZE3000_SW1BCONF , reg); +pmic_reg_write (dev,PFUZE3000_SW1BCONF ,0x40 );/* SW1B mode to APS/PFM */ - reg =0xc ; -pmic_reg_write (dev,PFUZE3000_SW1BMODE , reg); +pmic_reg_write (dev,PFUZE3000_SW1BMODE ,0xc );/* SW1B standby voltage set to 0.975V */ - reg =0xb ; -pmic_reg_write (dev,PFUZE3000_SW1BSTBY , reg); +pmic_reg_write (dev,PFUZE3000_SW1BSTBY ,0xb );return 0 ; }
Signature · 1 line
2.17.1
PATCH v2 1/1 mx6ul_14x14_evk: Simplify the PMIC register writes
Quoted 34 lines
-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: 2019年2月14日 21:36
To: sbabic at denx.de
Cc: u-boot at lists.denx.de; Peng Fan <[email protected]>; Fabio Estevam <[email protected]>
Subject: [PATCH v2]mx6ul_14x14_evk: Simplify the PMIC register writesThere is no need to store the values written to the PMIC inside the 'reg' variable. Make it simpler by writing the values directly.
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Remove 1/2 notation, since this is a standalome patch
- Add Peng Fan on Ccboard/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +1
-2@@ -86,16 +86,13 @@ int power_init_board(void)pmic_reg_write (dev,PFUZE3000_LDOGCTL , reg);/* SW1B step ramp up time from 2us to 4us/25mV */ - reg =0x40 ; -pmic_reg_write (dev,PFUZE3000_SW1BCONF , reg); +pmic_reg_write (dev,PFUZE3000_SW1BCONF ,0x40 );
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c int power_init_board(void) · line 95
Quoted 10 lines
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +2
-4/* SW1B mode to APS/PFM */ - reg =0xc ; -pmic_reg_write (dev,PFUZE3000_SW1BMODE , reg); +pmic_reg_write (dev,PFUZE3000_SW1BMODE ,0xc );/* SW1B standby voltage set to 0.975V */ - reg =0xb ; -pmic_reg_write (dev,PFUZE3000_SW1BSTBY , reg); +pmic_reg_write (dev,PFUZE3000_SW1BSTBY ,0xb );
Quoted 5 lines
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +0
-1return 0 ; } --2.17.1