Skip to contentSkip to conversation

warp7: Fix the write to the LDOGCTL PMIC register

PATCH New Fabio Estevam 1 participant 1 message Feb 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 warp7: Fix the write to the LDOGCTL PMIC register

The third parameter of the pmic_clrsetbits() function is the mask to the register and the correct mask is 1 not 0.

Since the LDOGCTL only contains a single valid bit (bit 0), we can use pmic_reg_write() and write 1 directly, which fixes the problem in a simpler way and use the original pmic function that was used prior to the DM PMIC conversion.

Fixes 8ba377321c86 ("arm: imx7s-warp: Convert to DM PMIC")

---
Changes since v1:
- Fix typo in commit message: "contains a single valid bit"

 board/warp7/warp7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/warp7/warp7.c +1 -1
index 49f290f978..2882dc9870 100644
@@ -77,7 +77,7 @@ int power_init_board(void)
 	printf("PMIC: PFUZE3000 DEV_ID=0x%x REV_ID=0x%x\n", dev_id, rev_id);
 
 	/* disable Low Power Mode during standby mode */
-	pmic_clrsetbits(dev, PFUZE3000_LDOGCTL, 0, 1);
+	pmic_reg_write(dev, PFUZE3000_LDOGCTL, 1);
 
 	return 0;
 }
Signature · 1 line
2.17.1