Skip to contentSkip to conversation

soc: qcom: rpmhpd: Set 'active_only' for active only power domains

PATCH In review Douglas Anderson 4 participants 5 messages Feb 14, 2019 – Nov 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: rpmhpd: Set 'active_only' for active only power domains

The 'active_only' attribute was accidentally never set to true for any power domains meaning that all the code handling this attribute was dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets this right.

Fixes 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")

---

 drivers/soc/qcom/rpmhpd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/soc/qcom/rpmhpd.c +2 -0
index 5741ec3fa814..51850cc68b70 100644
@@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
 
 static struct rpmhpd sdm845_mx_ao = {
 	.pd = { .name = "mx_ao", },
+	.active_only = true,
 	.peer = &sdm845_mx,
 	.res_name = "mx.lvl",
 };
@@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
 
 static struct rpmhpd sdm845_cx_ao = {
 	.pd = { .name = "cx_ao", },
+	.active_only = true,
 	.peer = &sdm845_cx,
 	.parent = &sdm845_mx_ao.pd,
 	.res_name = "cx.lvl",
Signature · 1 line
2.21.0.rc0.258.g878e2cd30e-goog
Reviewed-by on v1 1/1
#1 lore raw

Quoting Douglas Anderson (2019-02-14 09:36:33)

Quoted 10 lines

The 'active_only' attribute was accidentally never set to true for any power domains meaning that all the code handling this attribute was dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets this right.

Fixes 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")

---

Acked-by on v1 1/1
#2 lore raw
In reply to Douglas Anderson
Quoted 9 lines · Douglas Anderson

The 'active_only' attribute was accidentally never set to true for any power domains meaning that all the code handling this attribute was dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets this right.

Fixes 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")

Thanks for catching this. I seem to have introduced this bug when I moved away from using the macros to define these static structs and failed to add the property :/

Quoted 26 lines

---

  drivers/soc/qcom/rpmhpd.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/soc/qcom/rpmhpd.c +2 -0
index 5741ec3fa814..51850cc68b70 100644
@@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
 
  static struct rpmhpd sdm845_mx_ao = {
  	.pd = { .name = "mx_ao", },
+	.active_only = true,
  	.peer = &sdm845_mx,
  	.res_name = "mx.lvl",
  };
@@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
 
  static struct rpmhpd sdm845_cx_ao = {
  	.pd = { .name = "cx_ao", },
+	.active_only = true,
  	.peer = &sdm845_cx,
  	.parent = &sdm845_mx_ao.pd,
  	.res_name = "cx.lvl",
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#3 lore raw
In reply to Douglas Anderson

Bjorn / Andy,

Quoted 8 lines · Douglas Anderson

The 'active_only' attribute was accidentally never set to true for any power domains meaning that all the code handling this attribute was dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets this right.

Quoted 6 lines
Fixes 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")

---

 drivers/soc/qcom/rpmhpd.c | 2 ++
 1 file changed, 2 insertions(+)

Somehow this fell through the cracks and was never applied. Can you pick it up? Given that it's been a year and nobody has noticed this it seems like 5.5 is fine, but maybe you could add Cc: stable since it seems like something that stable trees would want...

Thanks!

-Doug

#4 lore raw
Quoted 18 lines · Doug Anderson

Bjorn / Andy,

Quoted 8 lines · Douglas Anderson

The 'active_only' attribute was accidentally never set to true for any power domains meaning that all the code handling this attribute was dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets this right.

Quoted 6 lines
Fixes 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")

---

 drivers/soc/qcom/rpmhpd.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 7 lines

Somehow this fell through the cracks and was never applied. Can you pick it up? Given that it's been a year and nobody has noticed this it seems like 5.5 is fine, but maybe you could add Cc: stable since it seems like something that stable trees would want...

Thanks!

Thanks for noticing, I've picked this up.

Regards,
Bjorn