xen/privcmd-buf.c: Convert to use vm_map_pages_zero()

PATCH Superseded Souptick Joarder 1 participant 1 message Feb 15, 2019

Subsystems (2)

Memory management Xen hypervisor interface

lore

Share & tools

lore

Souptick Joarder

author

2019-02-15 02:44 UTC #0 lore raw

PATCH v4 9/9 xen/privcmd-buf.c: Convert to use vm_map_pages_zero()

Convert to use vm_map_pages_zero() to map range of kernel memory to user vma.

This driver has ignored vm_pgoff. We could later "fix" these drivers to behave according to the normal vm_pgoff offsetting simply by removing the _zero suffix on the function name and if that causes regressions, it gives us an easy way to revert.

Signed-off-by Souptick Joarder <[email protected]>

Reviewed-by Boris Ostrovsky <[email protected]>

---
 drivers/xen/privcmd-buf.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

drivers/xen/privcmd-buf.c +2 -6

index de01a6d..d02dc43 100644
@@ -166,12 +166,8 @@ static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma)
 	if (vma_priv->n_pages != count)
 		ret = -ENOMEM;
 	else
-		for (i = 0; i < vma_priv->n_pages; i++) {
-			ret = vm_insert_page(vma, vma->vm_start + i * PAGE_SIZE,
-					     vma_priv->pages[i]);
-			if (ret)
-				break;
-		}
+		ret = vm_map_pages_zero(vma, vma_priv->pages,
+						vma_priv->n_pages);
 
 	if (ret)
 		privcmd_buf_vmapriv_free(vma_priv);

Signature · 1 line

1.9.1