Skip to contentSkip to conversation

bpf: make LWTUNNEL_BPF dependent on INET

PATCH Applied Peter Oskolkov 3 participants 3 messages Feb 15, 2019 – Feb 16, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bpf: make LWTUNNEL_BPF dependent on INET

Lightweight tunnels are L3 constructs that are used with IP/IP6.

For example, lwtunnel_xmit is called from ip_output.c and ip6_output.c only.

Make the dependency explicit at least for LWT-BPF, as now they call into IP routing.

V2: added "Reported-by" below.

---
 net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/Kconfig +1 -1
index 5cb9de1aaf88..62da6148e9f8 100644
@@ -403,7 +403,7 @@ config LWTUNNEL
 
 config LWTUNNEL_BPF
 	bool "Execute BPF program as route nexthop action"
-	depends on LWTUNNEL
+	depends on LWTUNNEL && INET
 	default y if LWTUNNEL=y
 	---help---
 	  Allows to run BPF programs as a nexthop action following a route
Signature · 1 line
2.21.0.rc0.258.g878e2cd30e-goog
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · Peter Oskolkov

Lightweight tunnels are L3 constructs that are used with IP/IP6.

For example, lwtunnel_xmit is called from ip_output.c and ip6_output.c only.

Quoted 7 lines

Make the dependency explicit at least for LWT-BPF, as now they call into IP routing.

V2: added "Reported-by" below.

Yes, that works. Thanks.

Quoted 18 lines
---
 net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/Kconfig +1 -1
index 5cb9de1aaf88..62da6148e9f8 100644
@@ -403,7 +403,7 @@ config LWTUNNEL
 
 config LWTUNNEL_BPF
 	bool "Execute BPF program as route nexthop action"
-	depends on LWTUNNEL
+	depends on LWTUNNEL && INET
 	default y if LWTUNNEL=y
 	---help---
 	  Allows to run BPF programs as a nexthop action following a route
Signature · 1 line
~Randy
#2 lore raw
Quoted 9 lines · Randy Dunlap
Quoted 8 lines · Peter Oskolkov

Lightweight tunnels are L3 constructs that are used with IP/IP6.

For example, lwtunnel_xmit is called from ip_output.c and ip6_output.c only.

Make the dependency explicit at least for LWT-BPF, as now they call into IP routing.

Quoted 8 lines
Quoted 4 lines

V2: added "Reported-by" below.

Yes, that works. Thanks.

Applied, thanks!