scsi: aacraid: Fix missing break in switch statement
Subsystems (2)
PATCH 1/1 scsi: aacraid: Fix missing break in switch statement
Add missing break statement and fix identation issue.
This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough.
--- drivers/scsi/aacraid/commsup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/aacraid/commsup.c +3 -2
@@ -1303,8 +1303,9 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr) ADD :DELETE ;break ; } -case AifBuManagerEvent: -aac_handle_aif_bu (dev, aifcmd); +break ; +case AifBuManagerEvent: +aac_handle_aif_bu (dev, aifcmd);break ; }
Signature · 1 line
2.20.1
Gustavo,
Quoted 1 line
Add missing break statement and fix identation issue.
So much bad indentation in this driver. Tried various tab widths and it is still all over the place.
Anyway. After staring at the firmware header I have convinced myself that your fix is correct. Applied to 5.1/scsi-queue.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Quoted 11 lines · Martin K. Petersen
Gustavo,
Quoted 1 line
Add missing break statement and fix identation issue.
So much bad indentation in this driver. Tried various tab widths and it is still all over the place.
Anyway. After staring at the firmware header I have convinced myself that your fix is correct. Applied to 5.1/scsi-queue.
That's great.
Thanks, Martin.
--
Gustavo