Skip to contentSkip to conversation

GigaDevice id update

PATCH Superseded Jiri Kastner 2 participants 3 messages Feb 18, 2019 Memory technology devices (MTD)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover GigaDevice id update

Vocore2 (mt76x8 device) has g25q128 flash, which is already in kernel's spi-nor.c

Jiri Kastner (1):
added missing GigaDevice chips

 drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 added missing GigaDevice chips

---
 drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +10 -0
index 3215e2431d..e4d05433a2 100644
@@ -106,6 +106,16 @@ const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("gd25q128", 0xc84018, 0, 64 * 1024, 128,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
+	{
+		INFO("gd25q256", 0xc84019, 0, 64 * 1024, 128,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 #endif
 #ifdef CONFIG_SPI_FLASH_ISSI		/* ISSI */
 	/* ISSI */
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/1 added missing GigaDevice chips

Hi Jiri,

Quoted 3 lines · Jiri Kastner
---
  drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

Please always add at least a small sentence in the commit text. And Cc the maintainers / custodians, in this case:

Jagan Teki <[email protected]>
Vignesh R <[email protected]>

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 110

Quoted 10 lines
drivers/mtd/spi/spi-nor-ids.c +2 -0
index 3215e2431d..e4d05433a2 100644
@@ -106,6 +106,16 @@ const struct flash_info spi_nor_ids[] = {
  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
  	},
+	{
+		INFO("gd25q128", 0xc84018, 0, 64 * 1024, 128,

This does not seem to be correct. The kernel version has:

		INFO("gd25q128", 0xc84018, 0, 64 * 1024, 256,

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 115

Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +5 -0
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
+	{
+		INFO("gd25q256", 0xc84019, 0, 64 * 1024, 128,

And here 512 please.

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 113

Quoted 3 lines
drivers/mtd/spi/spi-nor-ids.c +3 -0
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},

Thanks,
Stefan