carl9170: clean up a clamp() call
Subsystems (2)
PATCH 1/1 carl9170: clean up a clamp() call
The parameter order for clamp is supposed to be clamp(value, low, high). When we write it in this order it's equivalent to min(head->plcp[3] & 0x7f, 75) which works in this context where the min is zero. But it's not a correct use of the API.
--- drivers/net/wireless/ath/carl9170/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/carl9170/rx.c +1 -1
@@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,if (head->plcp[6 ] &0x80 ) status->enc_flags |=RX_ENC_FLAG_SHORT_GI ; - status->rate_idx =clamp (0 ,75 , head->plcp[3 ] &0x7f ); + status->rate_idx =clamp (head->plcp[3 ] &0x7f ,0 ,75 ); status->encoding =RX_ENC_HT ;break ;
Signature · 1 line
2.17.1
Quoted 6 lines · CET Dan Carpenter
The parameter order for clamp is supposed to be
clamp(value, low, high). When we write it in this order it's equivalent tomin(head->plcp[3] & 0x7f, 75)which works in this context where the min is zero. But it's not a correct use of the API.Signed-off-by Dan Carpenter <[email protected]>
Quoted 18 lines
--- drivers/net/wireless/ath/carl9170/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/ath/carl9170/rx.c +1
-1@@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,if (head->plcp[6 ] &0x80 ) status->enc_flags |=RX_ENC_FLAG_SHORT_GI ; - status->rate_idx =clamp (0 ,75 , head->plcp[3 ] &0x7f ); + status->rate_idx =clamp (head->plcp[3 ] &0x7f ,0 ,75 ); status->encoding =RX_ENC_HT ;break ;
Quoted 7 lines · Dan Carpenter
The parameter order for clamp is supposed to be
clamp(value, low, high). When we write it in this order it's equivalent tomin(head->plcp[3] & 0x7f, 75)which works in this context where the min is zero. But it's not a correct use of the API.Signed-off-by Dan Carpenter <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
dc76bb1e12e9 carl9170: clean up a clamp() call
Signature · 3 lines
https://patchwork.kernel.org/patch/10817541/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches