hwmon: (pmbus) Fix driver info initialization in probe routine
PATCH v2 1/1 hwmon: (pmbus) Fix driver info initialization in probe routine
Fix tps53679_probe() by using dynamically allocated "pmbus_driver_info" structure instead of static. Usage of static structures causes overwritten of the field "vrm_version", in case the system is equipped with several tps53679 devices with the different "vrm_version". In such case the last probed device overwrites this field for all others.
---v1->v2:
Comments pointed out by Guenter:
- Use devm_kmemdup().
--- drivers/hwmon/pmbus/tps53679.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/hwmon/pmbus/tps53679.c +8 -1
@@ -80,7 +80,14 @@ static struct pmbus_driver_info tps53679_info = {static int tps53679_probe (struct i2c_client *client,const struct i2c_device_id *id) { -return pmbus_do_probe (client, id, &tps53679_info); +struct pmbus_driver_info *info; + + info =devm_kmemdup (&client->dev, &tps53679_info,sizeof (*info), +GFP_KERNEL ); +if (!info) +return -ENOMEM ; + +return pmbus_do_probe (client, id, info); }static const struct i2c_device_id tps53679_id[] = {
Signature · 1 line
2.11.0
Quoted 9 lines · Vadim Pasternak
Fix
tps53679_probe()by using dynamically allocated "pmbus_driver_info" structure instead of static. Usage of static structures causes overwritten of the field "vrm_version", in case the system is equipped with several tps53679 devices with the different "vrm_version". In such case the last probed device overwrites this field for all others.Fixes 610526527a13 ("hwmon: (pmbus) Add support for Texas Instruments tps53679 device")Signed-off-by Vadim Pasternak <[email protected]>
Applied.
Thanks,
Guenter
Quoted 29 lines
---
v1->v2:
Comments pointed out by Guenter:
- Usedevm_kmemdup().--- drivers/hwmon/pmbus/tps53679.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)drivers/hwmon/pmbus/tps53679.c +8
-1@@ -80,7 +80,14 @@ static struct pmbus_driver_info tps53679_info = {static int tps53679_probe (struct i2c_client *client,const struct i2c_device_id *id) { -return pmbus_do_probe (client, id, &tps53679_info); +struct pmbus_driver_info *info; + + info =devm_kmemdup (&client->dev, &tps53679_info,sizeof (*info), +GFP_KERNEL ); +if (!info) +return -ENOMEM ; + +return pmbus_do_probe (client, id, info); }static const struct i2c_device_id tps53679_id[] = {