Skip to contentSkip to conversation

PCIE/PME: fix possible use-after-free on remove

PATCH Superseded Sven Van Asbroeck 2 participants 2 messages Feb 18, 2019 – Feb 25, 2019 PCI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCIE/PME: fix possible use-after-free on remove

In remove(), ensure that the pme work cannot run after kfree() is called. Otherwise, this could result in a use-after-free.

This issue was detected with the help of Coccinelle.

Cc Sinan Kaya <[email protected]>
Cc Frederick Lawler <[email protected]>
Cc Mika Westerberg <[email protected]>
Cc Keith Busch <[email protected]>
---
 drivers/pci/pcie/pme.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pci/pcie/pme.c +4 -1
index 0dbcf429089f..87823f669ccc 100644
@@ -427,9 +427,12 @@ static int pcie_pme_resume(struct pcie_device *srv)
  */
 static void pcie_pme_remove(struct pcie_device *srv)
 {
+	struct pcie_pme_service_data *data = get_service_data(srv);
+
 	pcie_pme_suspend(srv);
 	free_irq(srv->irq, srv);
-	kfree(get_service_data(srv));
+	cancel_work_sync(&data->work);
+	kfree(data);
 }
 
 static int pcie_pme_runtime_suspend(struct pcie_device *srv)
Signature · 1 line
2.17.1