Skip to contentSkip to conversation

staging:erofs: match alignment with open parenthesis

PATCH Superseded Bhanusree Pola 2 participants 2 messages Feb 19, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging:erofs: match alignment with open parenthesis

This patch fixes the checkpatch.pl issue:

CHECK: Alignment should match open parenthesis

---
 drivers/staging/erofs/dir.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/erofs/dir.c +4 -4
index 833f052f79d0..7a5daf8d8372 100644
@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
 };
 
 static int erofs_fill_dentries(struct dir_context *ctx,
-	void *dentry_blk, unsigned int *ofs,
-	unsigned int nameoff, unsigned int maxsize)
+			       void *dentry_blk, unsigned int *ofs,
+		 	       unsigned int nameoff, unsigned int maxsize)
 {
 	struct erofs_dirent *de = dentry_blk;
 	const struct erofs_dirent *end = dentry_blk + nameoff;
@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
 		nameoff = le16_to_cpu(de->nameoff);
 
 		if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
-			nameoff >= PAGE_SIZE)) {
+			     nameoff >= PAGE_SIZE)) {
 			errln("%s, invalid de[0].nameoff %u",
-				__func__, nameoff);
+			      __func__, nameoff);
 
 			err = -EIO;
 			goto skip_this;
Signature · 1 line
2.17.1
#1 lore raw

The subject line could be improved. If you look at prvious patches on this file, with git log --oneline, you will see that they all have a space after staging:

Whenever you send a patch, you should use the above command to see what others have done, rather than picking a subject line on your own.

I think you have also added [Outreachy kernel] to the subject like, in front of [PATCH]. This is not needed; the mailing list will add one for you.

Quoted 3 lines · Bhanusree Pola

This patch fixes the checkpatch.pl issue:

CHECK: Alignment should match open parenthesis

This is a pretty trivial change, so the above could be OK. But in general, the log message should say what you are doing and why (and the why should not be just "because checkpatch told me to" :). So here you could say:

Align code with the right side of an enclosing open parenthesis, to improve readability. Problem found using checkpatch.

julia

Quoted 42 lines
---
 drivers/staging/erofs/dir.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/erofs/dir.c +4 -5
index 833f052f79d0..7a5daf8d8372 100644
@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = {
 };
 
 static int erofs_fill_dentries(struct dir_context *ctx,
-	void *dentry_blk, unsigned int *ofs,
-	unsigned int nameoff, unsigned int maxsize)
+			       void *dentry_blk, unsigned int *ofs,
+		 	       unsigned int nameoff, unsigned int maxsize)
 {
 	struct erofs_dirent *de = dentry_blk;
 	const struct erofs_dirent *end = dentry_blk + nameoff;
@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
 		nameoff = le16_to_cpu(de->nameoff);
 
 		if (unlikely(nameoff < sizeof(struct erofs_dirent) ||
-			nameoff >= PAGE_SIZE)) {
+			     nameoff >= PAGE_SIZE)) {
 			errln("%s, invalid de[0].nameoff %u",
-				__func__, nameoff);
+			      __func__, nameoff);
 
 			err = -EIO;
 			goto skip_this;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190219071320.GA3265%40bhanusree-MacBookAir.
For more options, visit https://groups.google.com/d/optout.