Skip to contentSkip to conversation

target/arm: Stop unintentional sign extension in pmu_init

PATCH Applied Aaron Lindsay OS 2 participants 2 messages Feb 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/arm: Stop unintentional sign extension in pmu_init

This was introduced by
commit bf8d09694ccc07487cd73d7562081fdaec3370c8 target/arm: Don't clear supported PMU events when initializing PMCEID1
and identified by Coverity (CID 1398645).

---
 target/arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/arm/helper.c +1 -1
index a018eb23fe..5a29bc9799 100644
@@ -1167,7 +1167,7 @@ void pmu_init(ARMCPU *cpu)
 
         if (cnt->supported(&cpu->env)) {
             supported_event_map[cnt->number] = i;
-            uint64_t event_mask = 1 << (cnt->number & 0x1f);
+            uint64_t event_mask = 1ULL << (cnt->number & 0x1f);
             if (cnt->number & 0x20) {
                 cpu->pmceid1 |= event_mask;
             } else {
Signature · 1 line
2.20.1