Skip to contentSkip to conversation

scsi: qla2xxx: check for kstrtol() failure

PATCH New Dan Carpenter 1 participant 1 message Feb 20, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: check for kstrtol() failure

The error handling was unintentionally left out so it introduces a Smatch static checker warning:

drivers/scsi/qla2xxx/qla_attr.c:1655 qla2x00_port_speed_store()
error: uninitialized symbol 'type'.

Fixes a7b9ca7fc87a ("scsi: qla2xxx: Add support for setting port speed")
---
 drivers/scsi/qla2xxx/qla_attr.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/scsi/qla2xxx/qla_attr.c +2 -0
index 2eb1ae721a7d..f928c4d3a1ef 100644
@@ -1652,6 +1652,8 @@ qla2x00_port_speed_store(struct device *dev, struct device_attribute *attr,
 	}
 
 	rval = kstrtol(buf, 10, &type);
+	if (rval)
+		return rval;
 	speed = type;
 	if (type = 40 || type = 80 || type = 160 ||
 	    type = 320) {
Signature · 1 line
2.17.1