Skip to contentSkip to conversation

staging: netlogic: Add SPDX license Identifier

PATCH In review Bhanusree Pola 2 participants 4 messages Feb 21, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 staging: netlogic: Add SPDX license Identifier

adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning Issue found with checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

---
 drivers/staging/netlogic/xlr_net.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/netlogic/xlr_net.h +1 -0
index f76e16cfd15d..de51d64c1f23 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (c) 2003-2012 Broadcom Corporation
  * All Rights Reserved
Signature · 1 line
2.17.1
#1 lore raw
Quoted 14 lines · Bhanusree Pola

adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning Issue found with checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

---
 drivers/staging/netlogic/xlr_net.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/netlogic/xlr_net.h +0 -0
index f76e16cfd15d..de51d64c1f23 100644

drivers/staging/netlogic/xlr_net.h line 1

Quoted 1 line
drivers/staging/netlogic/xlr_net.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */

Wait, no, that is NOT the proper license for this file. The text below your added line spells that out in detail.

Never mess with licensing information unless you _REALLY_ know what you are doing, as doing it wrong (like this), is much more dangerous than leaving it alone.

So all of these are not correct at all, please be more careful.

thanks,

greg k-h

#2 lore raw
Quoted 20 lines · Greg Kroah-Hartman
Quoted 14 lines · Bhanusree Pola

adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning Issue found with checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

---
 drivers/staging/netlogic/xlr_net.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/netlogic/xlr_net.h +0 -0
index f76e16cfd15d..de51d64c1f23 100644

drivers/staging/netlogic/xlr_net.h line 1

Quoted 1 line
drivers/staging/netlogic/xlr_net.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */

Wait, no, that is NOT the proper license for this file. The text below your added line spells that out in detail.

Quoted 3 lines

Never mess with licensing information unless you _REALLY_ know what you are doing, as doing it wrong (like this), is much more dangerous than leaving it alone.

And, the reason that I didn't already put the proper SPDX line on these files is that _I_ don't even know what the correct line should be. Someone needs to do a bunch of research to determine that, if they really want to fix this up. Personally, there are many other more interesting things to do in the kernel than mess with this :)

thanks,

greg k-h

#3 lore raw
Quoted 26 lines · Greg Kroah-Hartman
Quoted 20 lines · Greg Kroah-Hartman
Quoted 14 lines · Bhanusree Pola

adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning Issue found with checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

---
 drivers/staging/netlogic/xlr_net.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/netlogic/xlr_net.h +0 -0
index f76e16cfd15d..de51d64c1f23 100644

drivers/staging/netlogic/xlr_net.h line 1

Quoted 1 line
drivers/staging/netlogic/xlr_net.h +1 -0
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */

Wait, no, that is NOT the proper license for this file. The text below your added line spells that out in detail.

Quoted 3 lines

Never mess with licensing information unless you _REALLY_ know what you are doing, as doing it wrong (like this), is much more dangerous than leaving it alone.

Quoted 5 lines

And, the reason that I didn't already put the proper SPDX line on these files is that _I_ don't even know what the correct line should be. Someone needs to do a bunch of research to determine that, if they really want to fix this up. Personally, there are many other more interesting things to do in the kernel than mess with this :)

ok. I'll take care of that. :)

Quoted 4 lines

thanks,

greg k-h