Make ARM_TIMER_SP804 depend on (ARM || ARM64)
PATCH RESEND 1/1 Make ARM_TIMER_SP804 depend on (ARM || ARM64)
Resending to incl. a proper mailing list and maintainers (not suggested by scripts/get_maintainer.pl)
This is only used on arm and arm64 platforms. Other timers also seem to depend on (ARM || ARM64).
After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
--- drivers/clocksource/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/Kconfig +1 -1
@@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER config ARM_TIMER_SP804 bool "Support for Dual Timer SP804 module" - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP select CLKSRC_MMIO select TIMER_OF if OF
Signature · 1 line
2.20.1
Quoted 19 lines · David Abdurachmanov
Resending to incl. a proper mailing list and maintainers (not suggested by
scripts/get_maintainer.pl)This is only used on arm and arm64 platforms. Other timers also seem to depend on (ARM || ARM64).
After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to add
CONFIG_ARM_TIMER_SP804=nto my config. This patch resolved the issue.Signed-off-by David Abdurachmanov <[email protected]>--- drivers/clocksource/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clocksource/Kconfig +0
-0
drivers/clocksource/Kconfig config ARM_GLOBAL_TIMER · line 372
Quoted 5 lines
drivers/clocksource/Kconfig +1
-1@@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER config ARM_TIMER_SP804 bool "Support for Dual Timer SP804 module" - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
What about adding the COMPILE_TEST option:
bool "Support for Dual Timer SP804 module" if COMPILE_TEST
but not add the ARM || ARM64 dependency ?
Quoted 4 lines
drivers/clocksource/Kconfig +0
-0select CLKSRC_MMIO select TIMER_OF if OF
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Quoted 29 lines · Daniel Lezcano
Quoted 19 lines · David Abdurachmanov
Resending to incl. a proper mailing list and maintainers (not suggested by
scripts/get_maintainer.pl)This is only used on arm and arm64 platforms. Other timers also seem to depend on (ARM || ARM64).
After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to add
CONFIG_ARM_TIMER_SP804=nto my config. This patch resolved the issue.Signed-off-by David Abdurachmanov <[email protected]>--- drivers/clocksource/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clocksource/Kconfig +0
-0drivers/clocksource/Kconfig config ARM_GLOBAL_TIMER · line 372
Quoted 5 lines
drivers/clocksource/Kconfig +1
-1@@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER config ARM_TIMER_SP804 bool "Support for Dual Timer SP804 module" - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUPWhat about adding the
COMPILE_TESToption:
Quoted 4 lines
bool "Support for Dual Timer SP804 module" if
COMPILE_TESTbut not add the ARM || ARM64 dependency ?
That would work, but is that consistent with other timers?
Looks like a number of them have depends on + COMPILE_TEST.
Some examples:
config ROCKCHIP_TIMER
bool "Rockchip timer driver" if COMPILE_TEST depends on ARM || ARM64
config ARMADA_370_XP_TIMER
bool "Armada 370 and XP timer driver" if COMPILE_TEST depends on ARM
config ORION_TIMER
bool "Orion timer driver" if COMPILE_TEST
depends on ARM
config ARM_GLOBAL_TIMER
bool "Support for the ARM global timer" if COMPILE_TEST select TIMER_OF if OF
depends on ARM
config CLKSRC_EXYNOS_MCT
bool "Exynos multi core timer driver" if COMPILE_TEST depends on ARM || ARM64
david
Quoted 13 lines
drivers/clocksource/Kconfig config ARM_GLOBAL_TIMER · line 375
Quoted 4 lines
drivers/clocksource/Kconfig +0
-0select CLKSRC_MMIO select TIMER_OF if OF--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCsFollow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Quoted 31 lines · David Abdurachmanov
Quoted 29 lines · Daniel Lezcano
Quoted 19 lines · David Abdurachmanov
Resending to incl. a proper mailing list and maintainers (not suggested by
scripts/get_maintainer.pl)This is only used on arm and arm64 platforms. Other timers also seem to depend on (ARM || ARM64).
After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to add
CONFIG_ARM_TIMER_SP804=nto my config. This patch resolved the issue.Signed-off-by David Abdurachmanov <[email protected]>--- drivers/clocksource/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clocksource/Kconfig +0
-0drivers/clocksource/Kconfig config ARM_GLOBAL_TIMER · line 372
Quoted 5 lines
drivers/clocksource/Kconfig +1
-1@@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER config ARM_TIMER_SP804 bool "Support for Dual Timer SP804 module" - depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP + depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUPWhat about adding the
COMPILE_TESToption:
Quoted 6 lines
Quoted 4 lines
bool "Support for Dual Timer SP804 module" if
COMPILE_TESTbut not add the ARM || ARM64 dependency ?
That would work, but is that consistent with other timers?
Yes, I'm making all timers to converge to COMPILE_TEST option.
Quoted 40 lines
Looks like a number of them have depends on +
COMPILE_TEST.Some examples:
config
ROCKCHIP_TIMER
bool "Rockchip timer driver" ifCOMPILE_TESTdepends on ARM || ARM64config
ARMADA_370_XP_TIMER
bool "Armada 370 and XP timer driver" ifCOMPILE_TESTdepends on ARMconfig
ORION_TIMER
bool "Orion timer driver" ifCOMPILE_TEST
depends on ARMconfig
ARM_GLOBAL_TIMER
bool "Support for the ARM global timer" ifCOMPILE_TESTselectTIMER_OFif OF
depends on ARMconfig
CLKSRC_EXYNOS_MCT
bool "Exynos multi core timer driver" ifCOMPILE_TESTdepends on ARM || ARM64david
Quoted 13 lines
drivers/clocksource/Kconfig config ARM_GLOBAL_TIMER · line 375
Quoted 4 lines
drivers/clocksource/Kconfig +0
-0select CLKSRC_MMIO select TIMER_OF if OF--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCsFollow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog