drm/nouveau/dmem: Fix a NULL vs IS_ERR() check
Subsystems (4)
PATCH 1/1 drm/nouveau/dmem: Fix a NULL vs IS_ERR() check
The hmm_devmem_add() function doesn't return NULL, it returns error pointers.
Fixes 5be73b690875 ("drm/nouveau/dmem: device memory helpers for SVM")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_dmem.c +1 -1
@@ -623,7 +623,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)*/ drm->dmem->devmem =hmm_devmem_add (&nouveau_dmem_devmem_ops, device, size); -if (drm->dmem->devmem ==NULL ) { +if (IS_ERR (drm->dmem->devmem)) {kfree (drm->dmem); drm->dmem =NULL ;return ;
Signature · 6 lines
2.17.1 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
Got it, thanks!
Quoted 24 lines · Dan Carpenter
The
hmm_devmem_add()function doesn't return NULL, it returns error pointers.Fixes 5be73b690875 ("drm/nouveau/dmem: device memory helpers for SVM")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nouveau_dmem.c +1
-2@@ -623,7 +623,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)*/ drm->dmem->devmem =hmm_devmem_add (&nouveau_dmem_devmem_ops, device, size); -if (drm->dmem->devmem ==NULL ) { +if (IS_ERR (drm->dmem->devmem)) {kfree (drm->dmem); drm->dmem =NULL ;return ; --
Quoted 2 lines
2.17.1
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau