Skip to contentSkip to conversation

mtdram: Add module parameter name.

PATCH In review Daniel Danzberger 3 participants 5 messages Feb 22, 2019 – Mar 7, 2019 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtdram: Add module parameter name.

This parameter will overwrite the default name "mtdram test device", when set.

---
 drivers/mtd/devices/mtdram.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mtd/devices/mtdram.c +4 -1
index 46238796145f..1a8ec3756a1d 100644
@@ -18,6 +18,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/mtdram.h>
 
+static char name[32] = "mtdram test device";
 static unsigned long total_size = CONFIG_MTDRAM_TOTAL_SIZE;
 static unsigned long erase_size = CONFIG_MTDRAM_ERASE_SIZE;
 static unsigned long writebuf_size = 64;
@@ -31,6 +32,8 @@ module_param(erase_size, ulong, 0);
 MODULE_PARM_DESC(erase_size, "Device erase block size in KiB");
 module_param(writebuf_size, ulong, 0);
 MODULE_PARM_DESC(writebuf_size, "Device write buf size in Bytes (Default: 64)");
+module_param_string(name, name, sizeof(name) - 1, 0);
+MODULE_PARM_DESC(name, "Device name");
 #endif
 
 // We could store these in the mtd structure, but we only support 1 device..
@@ -170,7 +173,7 @@ static int __init init_mtdram(void)
 		mtd_info = NULL;
 		return -ENOMEM;
 	}
-	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, "mtdram test device");
+	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, name);
 	if (err) {
 		vfree(addr);
 		kfree(mtd_info);
Signature · 6 lines
2.20.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer
#1 lore raw

Hi Daniel,

Please Cc: the MTD maintainers as advised by get_maintainers.pl.

Daniel Danzberger <[email protected]> wrote on Fri, 22 Feb 2019 13:32:05 +0100:

Quoted 1 line

This parameter will overwrite the default name "mtdram test device", when set.

Do you have a use case?

Quoted 19 lines
---
 drivers/mtd/devices/mtdram.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mtd/devices/mtdram.c +1 -0
index 46238796145f..1a8ec3756a1d 100644
@@ -18,6 +18,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/mtdram.h>
 
+static char name[32] = "mtdram test device";
 static unsigned long total_size = CONFIG_MTDRAM_TOTAL_SIZE;
 static unsigned long erase_size = CONFIG_MTDRAM_ERASE_SIZE;
 static unsigned long writebuf_size = 64;

drivers/mtd/devices/mtdram.c module_param(erase_size, ulong, 0); · line 35

Quoted 4 lines
drivers/mtd/devices/mtdram.c +1 -0
@@ -31,6 +32,8 @@ module_param(erase_size, ulong, 0);
 MODULE_PARM_DESC(erase_size, "Device erase block size in KiB");
 module_param(writebuf_size, ulong, 0);
 MODULE_PARM_DESC(writebuf_size, "Device write buf size in Bytes (Default: 64)");
+module_param_string(name, name, sizeof(name) - 1, 0);

The module_param_string kernel doc says

"@len: the maximum length of the string, incl. terminator"

and later

"@len is usually just sizeof(string)."

So I suppose sizeof(name) will be enough.

drivers/mtd/devices/mtdram.c static int __init init_mtdram(void) · line 179

Quoted 13 lines
drivers/mtd/devices/mtdram.c +2 -1
+MODULE_PARM_DESC(name, "Device name");
 #endif
 
 // We could store these in the mtd structure, but we only support 1 device..
@@ -170,7 +173,7 @@ static int __init init_mtdram(void)
 		mtd_info = NULL;
 		return -ENOMEM;
 	}
-	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, "mtdram test device");
+	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, name);
 	if (err) {
 		vfree(addr);
 		kfree(mtd_info);

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#2 lore raw
Quoted 11 lines · Miquel Raynal

Hi Daniel,

Please Cc: the MTD maintainers as advised by get_maintainers.pl.

Daniel Danzberger <[email protected]> wrote on Fri, 22 Feb 2019 13:32:05 +0100:

Quoted 1 line

This parameter will overwrite the default name "mtdram test device", when set.

Do you have a use case?

Me best guess is dealing with existing mtdparts.
...which is a sane use case IMHO.

If we add this feature to mtdram, we should consider it for nandsim too.

Signature · 6 lines
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#3 lore raw
In reply to Miquel Raynal
Quoted 10 lines · Miquel Raynal

Hi Daniel,

Please Cc: the MTD maintainers as advised by get_maintainers.pl.

Daniel Danzberger <[email protected]> wrote on Fri, 22 Feb 2019 13:32:05 +0100:

Quoted 1 line

This parameter will overwrite the default name "mtdram test device", when set.

Do you have a use case ?

I was testing some userspace mtd code that searches for a specific mtd partition by name. I didn't want to rename the partition name in the code every time I test with mtdram.
I was thinking someone else might run into a similar situation, so I pushed it upstream.

Quoted 54 lines
Quoted 20 lines
---
 drivers/mtd/devices/mtdram.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mtd/devices/mtdram.c +1 -0
index 46238796145f..1a8ec3756a1d 100644
@@ -18,6 +18,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/mtdram.h>
 
+static char name[32] = "mtdram test device";
 static unsigned long total_size = CONFIG_MTDRAM_TOTAL_SIZE;
 static unsigned long erase_size = CONFIG_MTDRAM_ERASE_SIZE;
 static unsigned long writebuf_size = 64;

drivers/mtd/devices/mtdram.c module_param(erase_size, ulong, 0); · line 35

Quoted 4 lines
drivers/mtd/devices/mtdram.c +1 -0
@@ -31,6 +32,8 @@ module_param(erase_size, ulong, 0);
 MODULE_PARM_DESC(erase_size, "Device erase block size in KiB");
 module_param(writebuf_size, ulong, 0);
 MODULE_PARM_DESC(writebuf_size, "Device write buf size in Bytes (Default: 64)");
+module_param_string(name, name, sizeof(name) - 1, 0);

The module_param_string kernel doc says

"@len: the maximum length of the string, incl. terminator"

and later

"@len is usually just sizeof(string)."

So I suppose sizeof(name) will be enough.Agree.

drivers/mtd/devices/mtdram.c static int __init init_mtdram(void) · line 179

Quoted 13 lines
drivers/mtd/devices/mtdram.c +2 -1
+MODULE_PARM_DESC(name, "Device name");
 #endif
 
 // We could store these in the mtd structure, but we only support 1 device..
@@ -170,7 +173,7 @@ static int __init init_mtdram(void)
 		mtd_info = NULL;
 		return -ENOMEM;
 	}
-	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, "mtdram test device");
+	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, name);
 	if (err) {
 		vfree(addr);
 		kfree(mtd_info);

Thanks,
Miquèl

Signature · 8 lines
Regards

Daniel Danzberger
embeDD GmbH, Alter Postplatz 2, CH-6370 Stans

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer
#4 lore raw
In reply to Daniel Danzberger

Hi Daniel,

Also, "mtd: mtdram:" would be a better prefix, and you can drop the period at the end of the commit title.

Daniel Danzberger <[email protected]> wrote on Fri, 22 Feb 2019 13:32:05 +0100:

Quoted 29 lines

This parameter will overwrite the default name "mtdram test device", when set.

---
 drivers/mtd/devices/mtdram.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mtd/devices/mtdram.c +3 -0
index 46238796145f..1a8ec3756a1d 100644
@@ -18,6 +18,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/mtdram.h>
 
+static char name[32] = "mtdram test device";
 static unsigned long total_size = CONFIG_MTDRAM_TOTAL_SIZE;
 static unsigned long erase_size = CONFIG_MTDRAM_ERASE_SIZE;
 static unsigned long writebuf_size = 64;
@@ -31,6 +32,8 @@ module_param(erase_size, ulong, 0);
 MODULE_PARM_DESC(erase_size, "Device erase block size in KiB");
 module_param(writebuf_size, ulong, 0);
 MODULE_PARM_DESC(writebuf_size, "Device write buf size in Bytes (Default: 64)");
+module_param_string(name, name, sizeof(name) - 1, 0);
+MODULE_PARM_DESC(name, "Device name");
 #endif
 
 // We could store these in the mtd structure, but we only support 1 device..

drivers/mtd/devices/mtdram.c static int __init init_mtdram(void) · line 179

Quoted 8 lines
drivers/mtd/devices/mtdram.c +1 -1
@@ -170,7 +173,7 @@ static int __init init_mtdram(void)
 		mtd_info = NULL;
 		return -ENOMEM;
 	}
-	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, "mtdram test device");
+	err = mtdram_init_device(mtd_info, addr, MTDRAM_TOTAL_SIZE, name);
 	if (err) {
 		vfree(addr);
 		kfree(mtd_info);

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/