Skip to contentSkip to conversation

au0828: minor fix to a misleading comment in _close()

PATCH Superseded Shuah Khan 2 participants 3 messages Feb 22, 2019 – Feb 25, 2019 Media (V4L/DVB)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Shuah Khan

author
#0 lore raw

PATCH 1/1 au0828: minor fix to a misleading comment in _close()

Fix misleading comment in _close()

---
 drivers/media/usb/au0828/au0828-video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/au0828/au0828-video.c +1 -1
index 7876c897cc1d..08f566006a1f 100644
@@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
 		 * so the s_power callback are silently ignored.
 		 * So, the current logic here does the following:
 		 * Disable (put tuner to sleep) when
-		 * - ALSA and DVB aren't not streaming;
+		 * - ALSA and DVB aren't streaming;
 		 * - the last V4L2 file handler is closed.
 		 *
 		 * FIXME:
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Shuah,

Thanks for your patch.

Quoted 12 lines · Shuah Khan

Fix misleading comment in _close()

---
 drivers/media/usb/au0828/au0828-video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/au0828/au0828-video.c +0 -0
index 7876c897cc1d..08f566006a1f 100644

drivers/media/usb/au0828/au0828-video.c static int au0828_v4l2_close(struct file *filp) · line 1077

Quoted 5 lines
drivers/media/usb/au0828/au0828-video.c +1 -1
@@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
 		 * so the s_power callback are silently ignored.
 		 * So, the current logic here does the following:
 		 * Disable (put tuner to sleep) when
-		 * - ALSA and DVB aren't not streaming;
+		 * - ALSA and DVB aren't streaming;

Nit-picking, as you are modifying the line anyhow I would s/;/./ With or without this changed,

Quoted 6 lines
drivers/media/usb/au0828/au0828-video.c +0 -0
 		 * - the last V4L2 file handler is closed.
 		 *
 		 * FIXME:
Signature · 1 line
2.17.1
Signature · 2 lines
Regards,
Niklas Söderlund
author
#2 lore raw
Quoted 12 lines · Niklas Söderlund

Hi Shuah,

Thanks for your patch.

Quoted 7 lines · Shuah Khan

Fix misleading comment in _close()

---
  drivers/media/usb/au0828/au0828-video.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

drivers/media/usb/au0828/au0828-video.c static int au0828_v4l2_close(struct file *filp) · line 1077

Quoted 10 lines
drivers/media/usb/au0828/au0828-video.c +1 -1
index 7876c897cc1d..08f566006a1f 100644
@@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
  		 * so the s_power callback are silently ignored.
  		 * So, the current logic here does the following:
  		 * Disable (put tuner to sleep) when
-		 * - ALSA and DVB aren't not streaming;
+		 * - ALSA and DVB aren't streaming;

Nit-picking, as you are modifying the line anyhow I would s/;/./ With or without this changed,

Thanks. I didn't notice that one. I might as fix it. Will send v2.

Quoted 3 lines

thanks,
-- Shuah