net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret'.
Subsystems (2)
PATCH 25/27 net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: db0342b20f32f584aedff27c9c09e0a4bbe5beff commit: 6c4128f658571b2dc7e01058ad09a8e947bc0159 [25/27] rhashtable: Remove obsolete rhashtable_walk_init function
smatch warnings:net/ipv6/ila/ila_xlat.c:420 ila_xlat_nl_cmd_flush() error: uninitialized symbol 'ret'.
# https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=6c4128f658571b2dc7e01058ad09a8e947bc0159
git remote add mac80211-next https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
git remote update mac80211-next
git checkout 6c4128f658571b2dc7e01058ad09a8e947bc0159
vim +/ret +420 net/ipv6/ila/ila_xlat.c
b6e71bde Tom Herbert 2018-06-27 378
b6e71bde Tom Herbert 2018-06-27 379 int ila_xlat_nl_cmd_flush(struct sk_buff *skb, struct genl_info *info)
b6e71bde Tom Herbert 2018-06-27 380 {
b6e71bde Tom Herbert 2018-06-27 381 struct net *net = genl_info_net(info);
b6e71bde Tom Herbert 2018-06-27 382 struct ila_net *ilan = net_generic(net, ila_net_id);
b6e71bde Tom Herbert 2018-06-27 383 struct rhashtable_iter iter;
b6e71bde Tom Herbert 2018-06-27 384 struct ila_map *ila;
b6e71bde Tom Herbert 2018-06-27 385 spinlock_t *lock;
b6e71bde Tom Herbert 2018-06-27 386 int ret;
b6e71bde Tom Herbert 2018-06-27 387
6c4128f6 Herbert Xu 2019-02-14 388 rhashtable_walk_enter(&ilan->xlat.rhash_table, &iter);
b6e71bde Tom Herbert 2018-06-27 389 rhashtable_walk_start(&iter);
b6e71bde Tom Herbert 2018-06-27 390
b6e71bde Tom Herbert 2018-06-27 391 for (;;) {
b6e71bde Tom Herbert 2018-06-27 392 ila = rhashtable_walk_next(&iter);
b6e71bde Tom Herbert 2018-06-27 393
b6e71bde Tom Herbert 2018-06-27 394 if (IS_ERR(ila)) {
b6e71bde Tom Herbert 2018-06-27 395 if (PTR_ERR(ila) == -EAGAIN)
b6e71bde Tom Herbert 2018-06-27 396 continue;
b6e71bde Tom Herbert 2018-06-27 397 ret = PTR_ERR(ila);
b6e71bde Tom Herbert 2018-06-27 398 goto done;
b6e71bde Tom Herbert 2018-06-27 399 } else if (!ila) {
b6e71bde Tom Herbert 2018-06-27 400 break;Set "ret" on this error path?
b6e71bde Tom Herbert 2018-06-27 401 } b6e71bde Tom Herbert 2018-06-27 402 b6e71bde Tom Herbert 2018-06-27 403 lock = lock_from_ila_map(ilan, ila); b6e71bde Tom Herbert 2018-06-27 404 b6e71bde Tom Herbert 2018-06-27 405 spin_lock(lock); b6e71bde Tom Herbert 2018-06-27 406 b6e71bde Tom Herbert 2018-06-27 407 ret = rhashtable_remove_fast(&ilan->xlat.rhash_table, b6e71bde Tom Herbert 2018-06-27 408 &ila->node, rht_params); b6e71bde Tom Herbert 2018-06-27 409 if (!ret) b6e71bde Tom Herbert 2018-06-27 410 ila_free_node(ila); b6e71bde Tom Herbert 2018-06-27 411 b6e71bde Tom Herbert 2018-06-27 412 spin_unlock(lock); b6e71bde Tom Herbert 2018-06-27 413 b6e71bde Tom Herbert 2018-06-27 414 if (ret) b6e71bde Tom Herbert 2018-06-27 415 break; b6e71bde Tom Herbert 2018-06-27 416 } b6e71bde Tom Herbert 2018-06-27 417 b6e71bde Tom Herbert 2018-06-27 418 done: b6e71bde Tom Herbert 2018-06-27 419 rhashtable_walk_stop(&iter);
b6e71bde Tom Herbert 2018-06-27 @420 return ret;b6e71bde Tom Herbert 2018-06-27 421 }b6e71bde Tom Herbert 2018-06-27 422
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
PATCH 1/1 ila: Fix uninitialised return value in ila_xlat_nl_cmd_flush
Quoted 6 lines · Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: db0342b20f32f584aedff27c9c09e0a4bbe5beff commit: 6c4128f658571b2dc7e01058ad09a8e947bc0159 [25/27] rhashtable: Remove obsolete rhashtable_walk_init functionsmatch warnings:
net/ipv6/ila/ila_xlat.c:420ila_xlat_nl_cmd_flush()error: uninitialized symbol 'ret'.
Thanks for catching this.
---8<---
This patch fixes an uninitialised return value error in ila_xlat_nl_cmd_flush.
net/ipv6/ila/ila_xlat.c +1 -1
@@ -383,7 +383,7 @@ int ila_xlat_nl_cmd_flush(struct sk_buff *skb, struct genl_info *info)struct rhashtable_iter iter;struct ila_map *ila;spinlock_t *lock; -int ret; +int ret =0 ;rhashtable_walk_enter (&ilan->xlat.rhash_table, &iter);rhashtable_walk_start (&iter);
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH] ila: Fix uninitialised return value in ila_xlat_nl_cmd_flush
From: Herbert Xu <[email protected]>
Date: Sat, 23 Feb 2019 13:30:47 +0800
Quoted 6 lines
This patch fixes an uninitialised return value error in
ila_xlat_nl_cmd_flush.Reported-by Dan Carpenter <[email protected]>Fixes 6c4128f65857 ("rhashtable: Remove obsolete...")Signed-off-by Herbert Xu <[email protected]>
Applied, thanks Herbert.