package/flatbuffers: do not install to target
PATCH 1/1 package/flatbuffers: do not install to target
Since flatbuffers does not have a shared library and flatc is only useful for compiling schemas of other projects, there is no point in installing flatbuffers in the target directory.
--- package/flatbuffers/flatbuffers.mk | 1 + 1 file changed, 1 insertion(+)
package/flatbuffers/flatbuffers.mk +1 -0
@@ -9,6 +9,7 @@ FLATBUFFERS_SITE = $(call github,google,flatbuffers,$(FLATBUFFERS_VERSION)) FLATBUFFERS_LICENSE = Apache-2.0 FLATBUFFERS_LICENSE_FILES = LICENSE.txt FLATBUFFERS_INSTALL_STAGING = YES +FLATBUFFERS_INSTALL_TARGET = NO FLATBUFFERS_CONF_OPTS += \ -DCMAKE_CXX_FLAGS="-std=c++11" \
Signature · 1 line
2.20.1
PATCH 1/1 package/flatbuffers: do not install to target
Hello,
Quoted 5 lines · On Mon, 25 Feb 2019 01:16:11 +0100 Micha?l Blanc <[email protected]> wrote:
Since flatbuffers does not have a shared library and flatc is only useful for compiling schemas of other projects, there is no point in installing flatbuffers in the target directory.
Signed-off-by Micha?l Blanc <[email protected]>
I see a shared library on the target:
??? usr
??? bin
??? ??? flatc
??? lib
??? ??? libflatbuffers.so -> libflatbuffers.so.1
??? ??? libflatbuffers.so.1 -> libflatbuffers.so.1.9.0
??? ??? libflatbuffers.so.1.9.0so it doesn't quite match with what your commit log says. Are you sure you were not building with BR2_STATIC_LIBS=y ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/flatbuffers: do not install to target
Le lun. 25 f?vr. 2019 ? 22:11, Thomas Petazzoni <
[email protected]> a ?crit :
Quoted 10 lines
I see a shared library on the target:
??? usr
??? bin ? ??? flatc ??? lib ? ??? libflatbuffers.so -> libflatbuffers.so.1 ? ??? libflatbuffers.so.1 -> libflatbuffers.so.1.9.0 ? ??? libflatbuffers.so.1.9.0
Quoted 3 lines
so it doesn't quite match with what your commit log says. Are you sure you were not building with BR2_STATIC_LIBS=y ?
I'm actually building with the default behavior, so shared libs only by default. I was mistaken in my commit message, I didn't check for the presence of a shared library. Flatbuffers is not supposed to be used with dynamic linking, despite it being possible. Maybe the patch should be dropped then.
Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190226/8989e24c/attachment.html>