Skip to contentSkip to conversation

efi_loader: memory type in device path allocation

RFC AKASHI Takahiro 1 participant 1 message Feb 25, 2019

lore
Share & tools
lore
#0 lore raw

In efi_device_path.c, dp_alloc() uses efi_allocate_pool() with EFI_ALLOCATE_ANY_PAGES.
This usage is just wrong as the first argument to efi_allocate_pool() should be of efi_mem_type, not "allocation type."

Since this routine is called as part of device path * protocol, I don't know what is the best value here. (EFI_BOOT_SERVICES_DATA as far as I looked into EDK2 shell implementation.)

-Takahiro Akashi