Skip to contentSkip to conversation

drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display

PATCH In review Andy Shevchenko 2 participants 3 messages Feb 25, 2019 – Feb 26, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tinydrm/ili9341: Support Adafruit 2.8" TFT display

The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one. Add support for it.

[1]: https://cdn-shop.adafruit.com/datasheets/MI0283QT-11+V1.1.PDF

---

- based on top of drm-tip

 drivers/gpu/drm/tinydrm/ili9341.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/tinydrm/ili9341.c +14 -3
index 3b7565a6311e..7e20d7f1b25f 100644
@@ -140,6 +140,10 @@ static const struct drm_display_mode yx240qv29_mode = {
 	DRM_SIMPLE_MODE(240, 320, 37, 49),
 };
 
+static const struct drm_display_mode dt280qv10_mode = {
+	DRM_SIMPLE_MODE(240, 320, 43, 58),
+};
+
 DEFINE_DRM_GEM_CMA_FOPS(ili9341_fops);
 
 static struct drm_driver ili9341_driver = {
@@ -155,25 +159,32 @@ static struct drm_driver ili9341_driver = {
 };
 
 static const struct of_device_id ili9341_of_match[] = {
-	{ .compatible = "adafruit,yx240qv29" },
+	{ .compatible = "adafruit,yx240qv29", .data = &yx240qv29_mode },
+	{ .compatible = "adafruit,dt280qv10", .data = &dt280qv10_mode },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ili9341_of_match);
 
 static const struct spi_device_id ili9341_id[] = {
-	{ "yx240qv29", 0 },
+	{ "yx240qv29", (kernel_ulong_t)&yx240qv29_mode },
+	{ "dt280qv10", (kernel_ulong_t)&dt280qv10_mode },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ili9341_id);
 
 static int ili9341_probe(struct spi_device *spi)
 {
+	const struct drm_display_mode *mode;
 	struct device *dev = &spi->dev;
 	struct mipi_dbi *mipi;
 	struct gpio_desc *dc;
 	u32 rotation = 0;
 	int ret;
 
+	mode = device_get_match_data(dev);
+	if (!mode)
+		return -ENODEV;
+
 	mipi = devm_kzalloc(dev, sizeof(*mipi), GFP_KERNEL);
 	if (!mipi)
 		return -ENOMEM;
@@ -201,7 +212,7 @@ static int ili9341_probe(struct spi_device *spi)
 		return ret;
 
 	ret = mipi_dbi_init(&spi->dev, mipi, &ili9341_pipe_funcs,
-			    &ili9341_driver, &yx240qv29_mode, rotation);
+			    &ili9341_driver, mode, rotation);
 	if (ret)
 		return ret;
 
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Den 25.02.2019 15.45, skrev Andy Shevchenko:

Quoted 4 lines

The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one. Add support for it.

[1]: https://cdn-shop.adafruit.com/datasheets/MI0283QT-11+V1.1.PDF

This one is supported by drivers/gpu/drm/tinydrm/mi0283qt.c. It was the first tinydrm driver and was named after the panel. Later we have grouped the panels by controller driver.

So ideally mi0283qt.c should have been merged with ili9341.c.

I know that this Adafruit display didn't always use a MI0283QT panel, so maybe earlier they did use the dt280qv10 panel you mention her.

The Watterott rpi-display also uses a MI0283QT panel.

Noralf.

Quoted 61 lines

---

- based on top of drm-tip

 drivers/gpu/drm/tinydrm/ili9341.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
drivers/gpu/drm/tinydrm/ili9341.c +13 -2
index 3b7565a6311e..7e20d7f1b25f 100644
@@ -140,6 +140,10 @@ static const struct drm_display_mode yx240qv29_mode = {
 	DRM_SIMPLE_MODE(240, 320, 37, 49),
 };
 
+static const struct drm_display_mode dt280qv10_mode = {
+	DRM_SIMPLE_MODE(240, 320, 43, 58),
+};
+
 DEFINE_DRM_GEM_CMA_FOPS(ili9341_fops);
 
 static struct drm_driver ili9341_driver = {
@@ -155,25 +159,32 @@ static struct drm_driver ili9341_driver = {
 };
 
 static const struct of_device_id ili9341_of_match[] = {
-	{ .compatible = "adafruit,yx240qv29" },
+	{ .compatible = "adafruit,yx240qv29", .data = &yx240qv29_mode },
+	{ .compatible = "adafruit,dt280qv10", .data = &dt280qv10_mode },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ili9341_of_match);
 
 static const struct spi_device_id ili9341_id[] = {
-	{ "yx240qv29", 0 },
+	{ "yx240qv29", (kernel_ulong_t)&yx240qv29_mode },
+	{ "dt280qv10", (kernel_ulong_t)&dt280qv10_mode },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ili9341_id);
 
 static int ili9341_probe(struct spi_device *spi)
 {
+	const struct drm_display_mode *mode;
 	struct device *dev = &spi->dev;
 	struct mipi_dbi *mipi;
 	struct gpio_desc *dc;
 	u32 rotation = 0;
 	int ret;
 
+	mode = device_get_match_data(dev);
+	if (!mode)
+		return -ENODEV;
+
 	mipi = devm_kzalloc(dev, sizeof(*mipi), GFP_KERNEL);
 	if (!mipi)
 		return -ENOMEM;

drivers/gpu/drm/tinydrm/ili9341.c static int ili9341_probe(struct spi_device *spi) · line 218

Quoted 8 lines
drivers/gpu/drm/tinydrm/ili9341.c +1 -1
@@ -201,7 +212,7 @@ static int ili9341_probe(struct spi_device *spi)
 		return ret;
 
 	ret = mipi_dbi_init(&spi->dev, mipi, &ili9341_pipe_funcs,
-			    &ili9341_driver, &yx240qv29_mode, rotation);
+			    &ili9341_driver, mode, rotation);
 	if (ret)
 		return ret;
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 11 lines · Noralf Trønnes

Den 25.02.2019 15.45, skrev Andy Shevchenko:

Quoted 4 lines

The Adafruit 2.8" TFT display [1] has different dimensions than 2.4" one. Add support for it.

[1]: https://cdn-shop.adafruit.com/datasheets/MI0283QT-11+V1.1.PDF

This one is supported by drivers/gpu/drm/tinydrm/mi0283qt.c. It was the first tinydrm driver and was named after the panel. Later we have grouped the panels by controller driver.

Yeah, thanks. It works.

Quoted 1 line

So ideally mi0283qt.c should have been merged with ili9341.c.

Yes, that's would be nice! Though we need still some unified compatible strings, while leaving old in place.

Quoted 2 lines

I know that this Adafruit display didn't always use a MI0283QT panel, so maybe earlier they did use the dt280qv10 panel you mention her.

The datasheet they point me to is for mi0283qt, but on the panel itself it's written dt280qv10. I dunno if it refers to the same or not.

Quoted 1 line

The Watterott rpi-display also uses a MI0283QT panel.

Signature · 8 lines
With Best Regards,
Andy Shevchenko


_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel