Skip to contentSkip to conversation

usb: typec: pi3usb30532: Keep orientation when setting mux to safe mode

DISCUSSION Heikki Krogerus 1 participant 1 message Feb 25, 2019 USB

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Hans de Goede

Keep the orientation value when setting the mux to safe mode, this fixes the orientation getting reset when switching alt-modes.

Should this be also a fix?

Quoted 20 lines
---
 drivers/usb/typec/mux/pi3usb30532.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/typec/mux/pi3usb30532.c +2 -1
index 64eb5983e17a..9294e85fd34b 100644
@@ -84,7 +84,8 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
 
 	switch (state) {
 	case TYPEC_STATE_SAFE:
-		new_conf = PI3USB30532_CONF_OPEN;
+		new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
+			   PI3USB30532_CONF_OPEN;
 		break;
 	case TYPEC_STATE_USB:
 		new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
Signature · 1 line
2.20.1

thanks,