tty: hvc_xen: Mark expected switch fall-through
PATCH 1/1 tty: hvc_xen: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/tty/hvc/hvc_xen.c: In function ‘xencons_backend_changed’:drivers/tty/hvc/hvc_xen.c:493:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->state == XenbusStateClosed)
^
drivers/tty/hvc/hvc_xen.c:496:2: note: here
case XenbusStateClosing:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/tty/hvc/hvc_xen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/hvc/hvc_xen.c +1 -1
@@ -492,7 +492,7 @@ static void xencons_backend_changed(struct xenbus_device *dev,case XenbusStateClosed:if (dev->state == XenbusStateClosed)break ; -/* Missed the backend's CLOSING state -- fallthrough */ +/* fall through - Missed the backend's CLOSING state. */ case XenbusStateClosing:xenbus_frontend_closed (dev);break ;
Signature · 1 line
2.20.1