file-posix: add drop-cache=on|off option
PATCH 1/1 file-posix: add drop-cache=on|off option
Commit dd577a26ff03b6829721b1ffbbf9e7c411b72378 ("block/file-posix:
implement bdrv_co_invalidate_cache() on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux.
The invalidation takes a significant amount of time when the file is large and present in the page cache. Normally this is not the case for cross-host live migration but it can happen when migrating between QEMU processes on the same host.
On same-host migration we don't need to invalidate pages for correctness anyway, so an option to skip page cache invalidation is useful. I investigated optimizing invalidation and detecting same-host migration, but both are hard to achieve so a user-visible option will suffice.
As a bonus this option means that the cache invalidation feature will now be detectable by libvirt via QMP schema introspection.
--- qapi/block-core.json | 5 +++++ block/file-posix.c | 14 ++++++++++++++ 2 files changed, 19 insertions(+)
qapi/block-core.json +5 -0
@@ -2807,6 +2807,10 @@ # @locking: whether to enable file locking. If set to 'auto', only enable # when Open File Descriptor (OFD) locking API is available # (default: auto, since 2.10) +# @drop-cache: invalidate page cache during live migration. This prevents +# stale data on the migration destination with cache.direct=off. +# Currently only supported on Linux hosts. +# (default: on, since: 4.0) # @x-check-cache-dropped: whether to check that page cache was dropped on live # migration. May cause noticeable delays if the image # file is large, do not use in production.
@@ -2819,6 +2823,7 @@ '*pr-manager': 'str', '*locking': 'OnOffAuto', '*aio': 'BlockdevAioOptions', + '*drop-cache': 'bool', '*x-check-cache-dropped': 'bool' } } ##
block/file-posix.c +14 -0
@@ -154,6 +154,7 @@ typedef struct BDRVRawState { bool page_cache_inconsistent:1;bool has_fallocate;bool needs_alignment; +bool drop_cache;bool check_cache_dropped;PRManager *pr_mgr;
@@ -162,6 +163,7 @@ typedef struct BDRVRawState {typedef struct BDRVRawReopenState {int fd;int open_flags; +bool drop_cache;bool check_cache_dropped; }BDRVRawReopenState ;
@@ -422,6 +424,11 @@ static QemuOptsList raw_runtime_opts = { .type = QEMU_OPT_STRING, .help = "id of persistent reservation manager object (default: none)", }, + { + .name = "drop-cache", + .type = QEMU_OPT_BOOL, + .help = "invalidate page cache during live migration (default: on)", + }, { .name = "x-check-cache-dropped", .type = QEMU_OPT_BOOL,
@@ -511,6 +518,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, } } + s->drop_cache =qemu_opt_get_bool (opts,"drop-cache" , true); s->check_cache_dropped =qemu_opt_get_bool (opts,"x-check-cache-dropped" , false);
@@ -869,6 +877,7 @@ static int raw_reopen_prepare(BDRVReopenState *state, goto out; } + rs->drop_cache =qemu_opt_get_bool_del (opts,"drop-cache" , true); rs->check_cache_dropped =qemu_opt_get_bool_del (opts,"x-check-cache-dropped" , false);
@@ -946,6 +955,7 @@ static void raw_reopen_commit(BDRVReopenState *state)BDRVRawState *s = state->bs->opaque;Error *local_err =NULL ; + s->drop_cache = rs->drop_cache; s->check_cache_dropped = rs->check_cache_dropped; s->open_flags = rs->open_flags;
@@ -2531,6 +2541,10 @@ static void coroutine_fn raw_co_invalidate_cache(BlockDriverState *bs,return ; } +if (!s->drop_cache) { +return ; + } +if (s->open_flags &O_DIRECT ) {return ;/* No host kernel page cache */ }
Signature · 1 line
2.20.1
Quoted 9 lines · Stefan Hajnoczi
Commit
dd577a26ff03b6829721b1ffbbf9e7c411b72378("block/file-posix:
implementbdrv_co_invalidate_cache()on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux.The invalidation takes a significant amount of time when the file is large and present in the page cache. Normally this is not the case for cross-host live migration but it can happen when migrating between QEMU processes on the same host.
Quoted 7 lines
On same-host migration we don't need to invalidate pages for correctness anyway, so an option to skip page cache invalidation is useful. I investigated optimizing invalidation and detecting same-host migration, but both are hard to achieve so a user-visible option will suffice.
As a bonus this option means that the cache invalidation feature will now be detectable by libvirt via QMP schema introspection.
Do you still want to pursue the QMP query-qemu-features command, or does this delay that for another day?
Quoted 8 lines
Suggested-by Neil Skrypuch <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>--- qapi/block-core.json | 5 +++++ block/file-posix.c | 14 ++++++++++++++ 2 files changed, 19 insertions(+)
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Quoted 15 lines · Eric Blake
Quoted 14 lines · Stefan Hajnoczi
Commit
dd577a26ff03b6829721b1ffbbf9e7c411b72378("block/file-posix:
implementbdrv_co_invalidate_cache()on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux.The invalidation takes a significant amount of time when the file is large and present in the page cache. Normally this is not the case for cross-host live migration but it can happen when migrating between QEMU processes on the same host.
On same-host migration we don't need to invalidate pages for correctness anyway, so an option to skip page cache invalidation is useful. I investigated optimizing invalidation and detecting same-host migration, but both are hard to achieve so a user-visible option will suffice.
Quoted 5 lines
Quoted 2 lines
As a bonus this option means that the cache invalidation feature will now be detectable by libvirt via QMP schema introspection.
Do you still want to pursue the QMP query-qemu-features command, or does this delay that for another day?
The presence of this new option doesn't guarantee that dropping caches works. It is currently only implemented on Linux.
We still need query-qemu-features so that libvirt can detect whether this QEMU binary can drop caches (e.g. on Linux vs FreeBSD).
Stefan
Quoted 19 lines · Stefan Hajnoczi
Quoted 18 lines · Eric Blake
Quoted 16 lines · Stefan Hajnoczi
Commit
dd577a26ff03b6829721b1ffbbf9e7c411b72378("block/file-posix:
implementbdrv_co_invalidate_cache()on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux.The invalidation takes a significant amount of time when the file is large and present in the page cache. Normally this is not the case for cross-host live migration but it can happen when migrating between QEMU processes on the same host.
On same-host migration we don't need to invalidate pages for correctness anyway, so an option to skip page cache invalidation is useful. I investigated optimizing invalidation and detecting same-host migration, but both are hard to achieve so a user-visible option will suffice.
As a bonus this option means that the cache invalidation feature will now be detectable by libvirt via QMP schema introspection.
Quoted 8 lines
Quoted 2 lines
Do you still want to pursue the QMP query-qemu-features command, or does this delay that for another day?
The presence of this new option doesn't guarantee that dropping caches works. It is currently only implemented on Linux.
We still need query-qemu-features so that libvirt can detect whether this QEMU binary can drop caches (e.g. on Linux vs FreeBSD).
The commit message said that libvirt would use this new option to detect availability of the cache drop feature. That should probably be removed from the commit message, as this caveat about non-portable impl means libvirt can't actually rely on it.
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 26 lines · Daniel P. Berrangé
Quoted 25 lines · Stefan Hajnoczi
Quoted 15 lines · Eric Blake
Quoted 14 lines · Stefan Hajnoczi
Commit
dd577a26ff03b6829721b1ffbbf9e7c411b72378("block/file-posix:
implementbdrv_co_invalidate_cache()on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux.The invalidation takes a significant amount of time when the file is large and present in the page cache. Normally this is not the case for cross-host live migration but it can happen when migrating between QEMU processes on the same host.
On same-host migration we don't need to invalidate pages for correctness anyway, so an option to skip page cache invalidation is useful. I investigated optimizing invalidation and detecting same-host migration, but both are hard to achieve so a user-visible option will suffice.
Quoted 5 lines
Quoted 2 lines
As a bonus this option means that the cache invalidation feature will now be detectable by libvirt via QMP schema introspection.
Do you still want to pursue the QMP query-qemu-features command, or does this delay that for another day?
The presence of this new option doesn't guarantee that dropping caches works. It is currently only implemented on Linux.
Quoted 7 lines
Quoted 2 lines
We still need query-qemu-features so that libvirt can detect whether this QEMU binary can drop caches (e.g. on Linux vs FreeBSD).
The commit message said that libvirt would use this new option to detect availability of the cache drop feature. That should probably be removed from the commit message, as this caveat about non-portable impl means libvirt can't actually rely on it.
Okay, will fix.
Stefan
Quoted 6 lines · EST Stefan Hajnoczi
Suggested-by Neil Skrypuch <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>--- qapi/block-core.json | 5 +++++ block/file-posix.c | 14 ++++++++++++++ 2 files changed, 19 insertions(+)
Applied this patch against 3.1.0 and tested with -drive ...,file.drop- cache=off and it resolves the issue mentioned in my previous email to the list, "[regression] Clock jump on VM migration".
Thanks,
- Neil
Quoted 17 lines · Stefan Hajnoczi
Commit
dd577a26ff03b6829721b1ffbbf9e7c411b72378("block/file-posix:
implementbdrv_co_invalidate_cache()on Linux") introduced page cache invalidation so that cache.direct=off live migration is safe on Linux.The invalidation takes a significant amount of time when the file is large and present in the page cache. Normally this is not the case for cross-host live migration but it can happen when migrating between QEMU processes on the same host.
On same-host migration we don't need to invalidate pages for correctness anyway, so an option to skip page cache invalidation is useful. I investigated optimizing invalidation and detecting same-host migration, but both are hard to achieve so a user-visible option will suffice.
As a bonus this option means that the cache invalidation feature will now be detectable by libvirt via QMP schema introspection.
Quoted 7 lines
Suggested-by Neil Skrypuch <[email protected]>Signed-off-by Stefan Hajnoczi <[email protected]>--- qapi/block-core.json | 5 +++++ block/file-posix.c | 14 ++++++++++++++ 2 files changed, 19 insertions(+)