Skip to contentSkip to conversation

usb: typec: altmodes/displayport: Fall back to multi-func pins

DISCUSSION Heikki Krogerus 1 participant 1 message Feb 27, 2019 USB

lore
Share & tools
lore
#0 lore raw
Quoted 14 lines · Hans de Goede

Hi Heikki,

Quoted 11 lines · Heikki Krogerus
Quoted 10 lines · Hans de Goede

If our port-partner supports both DP-only operation (pin-assignment C) and multi-func operation (pin-assignment D) and we only support pin-assignment D and the port-partner prefers DP-only mode, then before this commit we would and up masking out pin-assignment D from the available pin-assignments and fail to pick a pin-assignment.

Instead only mask out the multi-func pin-assignments if we support dp-only pin-assignments, so that we correctly fall-back to a multi-func pin-assignment in this case (by picking pin-assignment D).

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Should this be handled as a fix?

AFAIK they are no users if this yet, until we've agreement on the DT bindings and code merged for adding alt-modes to an usb-connector node, nothing will be using this code, so I see little use in adding a Cc: stable or some such.

True.

thanks,