habanalabs: make functions static or declare them
PATCH 1/1 habanalabs: make functions static or declare them
This patch fixes the below sparse warnings by either making the functions static or by adding a declaration in the relevant header file.
In addition, the patch removes goya_mmap completely as it doesn't add any additional benefit.
Fixes the following sparse warnings:
drivers/misc/habanalabs/habanalabs_drv.c:24:1: warning: symbol 'hl_devs_idr' was not declared. Should it be static? drivers/misc/habanalabs/habanalabs_drv.c:25:1: warning: symbol 'hl_devs_idr_lock' was not declared. Should it be static? drivers/misc/habanalabs/memory.c:1451:5: warning: symbol 'hl_vm_ctx_init_with_ranges' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:396:5: warning: symbol 'goya_send_pci_access_msg' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:417:5: warning: symbol 'goya_pci_bars_map' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:557:6: warning: symbol 'goya_reset_link_through_bridge' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:774:5: warning: symbol 'goya_early_fini' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:857:6: warning: symbol 'goya_late_fini' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:971:5: warning: symbol 'goya_sw_fini' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:1233:5: warning: symbol 'goya_init_cpu_queues' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:2914:5: warning: symbol 'goya_suspend' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:2939:5: warning: symbol 'goya_resume' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:2952:5: warning: symbol 'goya_mmap' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:2957:5: warning: symbol 'goya_cb_mmap' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:2973:6: warning: symbol 'goya_ring_doorbell' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3063:6: warning: symbol 'goya_flush_pq_write' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3068:6: warning: symbol 'goya_dma_alloc_coherent' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3074:6: warning: symbol 'goya_dma_free_coherent' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3080:6: warning: symbol 'goya_get_int_queue_base' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3138:5: warning: symbol 'goya_send_job_on_qman0' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3295:5: warning: symbol 'goya_test_queue' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3417:6: warning: symbol 'goya_dma_pool_zalloc' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3426:6: warning: symbol 'goya_dma_pool_free' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3432:6: warning: symbol 'goya_cpu_accessible_dma_pool_alloc' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3448:6: warning: symbol 'goya_cpu_accessible_dma_pool_free' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3458:5: warning: symbol 'goya_dma_map_sg' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3467:6: warning: symbol 'goya_dma_unmap_sg' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:3473:5: warning: symbol 'goya_get_dma_desc_list_size' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4210:5: warning: symbol 'goya_parse_cb_no_mmu' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4261:5: warning: symbol 'goya_parse_cb_no_ext_quque' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4294:5: warning: symbol 'goya_cs_parser' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4307:6: warning: symbol 'goya_add_end_of_cb_packets' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4334:5: warning: symbol 'goya_context_switch' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4426:6: warning: symbol 'goya_restore_phase_topology' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4460:5: warning: symbol 'goya_debugfs_read32' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4510:5: warning: symbol 'goya_debugfs_write32' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4738:6: warning: symbol 'goya_handle_eqe' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:4836:6: warning: symbol 'goya_get_events_stat' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:5075:5: warning: symbol 'goya_send_heartbeat' was not declared. Should it be static? drivers/misc/habanalabs/goya/goya.c:5253:5: warning: symbol 'goya_get_eeprom_data' was not declared. Should it be static?
--- drivers/misc/habanalabs/device.c | 2 +- drivers/misc/habanalabs/goya/goya.c | 73 +++++++++++------------- drivers/misc/habanalabs/goya/goyaP.h | 16 ++++++ drivers/misc/habanalabs/habanalabs.h | 2 - drivers/misc/habanalabs/habanalabs_drv.c | 4 +- drivers/misc/habanalabs/memory.c | 2 +- 6 files changed, 54 insertions(+), 45 deletions(-)
drivers/misc/habanalabs/device.c +1 -1
@@ -93,7 +93,7 @@ static int hl_mmap(struct file *filp, struct vm_area_struct *vma)return hl_cb_mmap (hpriv, vma); } -return hpriv->hdev->asic_funcs->mmap (hpriv, vma); +return -EINVAL ; }static const struct file_operations hl_ops = {
drivers/misc/habanalabs/goya/goya.c +34 -39
218 lines not on this page · raw message
drivers/misc/habanalabs/goya/goyaP.h +16 -0
@@ -187,4 +187,20 @@ void goya_init_security(struct hl_device *hdev);u64 goya_get_max_power (struct hl_device *hdev);void goya_set_max_power (struct hl_device *hdev,u64 value); +int goya_send_pci_access_msg (struct hl_device *hdev,u32 opcode); +void goya_late_fini (struct hl_device *hdev); +int goya_suspend (struct hl_device *hdev); +int goya_resume (struct hl_device *hdev); +void goya_flush_pq_write (struct hl_device *hdev,u64 *pq,u64 exp_val); +void goya_handle_eqe (struct hl_device *hdev,struct hl_eq_entry *eq_entry); +void *goya_get_events_stat (struct hl_device *hdev,u32 *size); +void goya_add_end_of_cb_packets (u64 kernel_address,u32 len,u64 cq_addr, +u32 cq_val,u32 msix_vec); +int goya_cs_parser (struct hl_device *hdev,struct hl_cs_parser *parser); +void *goya_get_int_queue_base (struct hl_device *hdev,u32 queue_id, +dma_addr_t *dma_handle,u16 *queue_len); +u32 goya_get_dma_desc_list_size (struct hl_device *hdev,struct sg_table *sgt); +int goya_test_queue (struct hl_device *hdev,u32 hw_queue_id); +int goya_send_heartbeat (struct hl_device *hdev); +#endif /* GOYAP_H_ */
drivers/misc/habanalabs/habanalabs.h +0 -2
@@ -428,7 +428,6 @@ enum hl_pll_frequency {* hw_fini and before CS rollback. * @suspend: handles IP specific H/W or SW changes for suspend. * @resume: handles IP specific H/W or SW changes for resume. -* @mmap: mmap function, does nothing. * @cb_mmap: maps a CB. * @ring_doorbell: increment PI on a given QMAN. * @flush_pq_write: flush PQ entry write if necessary, WARN if flushing failed.
@@ -491,7 +490,6 @@ struct hl_asic_funcs {void (*halt_engines)(struct hl_device *hdev,bool hard_reset);int (*suspend)(struct hl_device *hdev);int (*resume)(struct hl_device *hdev); -int (*mmap)(struct hl_fpriv *hpriv,struct vm_area_struct *vma);int (*cb_mmap)(struct hl_device *hdev,struct vm_area_struct *vma,u64 kaddress,phys_addr_t paddress,u32 size);void (*ring_doorbell)(struct hl_device *hdev,u32 hw_queue_id,u32 pi);
drivers/misc/habanalabs/habanalabs_drv.c +2 -2
@@ -21,8 +21,8 @@ MODULE_LICENSE("GPL v2");static int hl_major;static struct class *hl_class; -DEFINE_IDR (hl_devs_idr); -DEFINE_MUTEX (hl_devs_idr_lock); +static DEFINE_IDR (hl_devs_idr); +static DEFINE_MUTEX (hl_devs_idr_lock);static int timeout_locked =5 ;static int reset_on_lockup =1 ;
drivers/misc/habanalabs/memory.c +1 -1
@@ -1448,7 +1448,7 @@ static int hl_va_range_init(struct hl_device *hdev,* - Virtual address to area descriptor hashtable * - Virtual block list of available virtual memory */ -int hl_vm_ctx_init_with_ranges (struct hl_ctx *ctx,u64 host_range_start, +static int hl_vm_ctx_init_with_ranges (struct hl_ctx *ctx,u64 host_range_start,u64 host_range_end,u64 dram_range_start,u64 dram_range_end) {
Signature · 1 line
2.18.0