migration: support for authorization control on TLS connections
cover migration: support for authorization control on TLS connections
This series provides the migration part of the authorization control series previously posted as:
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg04319.html
The core authz framework is now merged & this patch has had positive review. Thus this migration part is ready to go into the migration maintainer's tree, should the maintainer consider them acceptable.
Daniel P. Berrangé (1):
migration: add support for a "tls-authz" migration parameter
hmp.c | 9 +++++++++ migration/migration.c | 8 ++++++++ migration/tls.c | 2 +- qapi/migration.json | 14 +++++++++++++- 4 files changed, 31 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/1 migration: add support for a "tls-authz" migration parameter
From: "Daniel P. Berrange" <[email protected]>
The QEMU instance that runs as the server for the migration data transport (ie the target QEMU) needs to be able to configure access control so it can prevent unauthorized clients initiating an incoming migration. This adds a new 'tls-authz' migration parameter that is used to provide the QOM ID of a QAuthZ subclass instance that provides the access control check. This is checked against the x509 certificate obtained during the TLS handshake.
For example, when starting a QEMU for incoming migration, it is possible to give an example identity of the source QEMU that is intended to be connecting later:
$QEMU \
-monitor stdio \
-incoming defer \
...other args...
(qemu) object_add tls-creds-x509,id=tls0,dir=/home/berrange/qemutls,\
endpoint=server,verify-peer=yes \
(qemu) object_add authz-simple,id=auth0,identity=CN=laptop.example.com,,\
O=Example Org,,L=London,,ST=London,,C=GB \
(qemu) migrate_incoming tcp:localhost:9000--- hmp.c | 9 +++++++++ migration/migration.c | 8 ++++++++ migration/tls.c | 2 +- qapi/migration.json | 14 +++++++++++++- 4 files changed, 31 insertions(+), 2 deletions(-)
hmp.c +9 -0
@@ -398,6 +398,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)monitor_printf (mon,"%s: %" PRIu64"\n" ,MigrationParameter_str (MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH ), params->max_postcopy_bandwidth); +monitor_printf (mon," %s: '%s'\n" , +MigrationParameter_str (MIGRATION_PARAMETER_TLS_AUTHZ ), + params->has_tls_authz ? params->tls_authz :"" ); }qapi_free_MigrationParameters (params);
@@ -1709,6 +1712,12 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) p->tls_hostname->type =QTYPE_QSTRING ;visit_type_str (v, param, &p->tls_hostname->u.s, &err);break ; +case MIGRATION_PARAMETER_TLS_AUTHZ : + p->has_tls_authz = true; + p->tls_authz =g_new0 (StrOrNull,1 ); + p->tls_authz->type =QTYPE_QSTRING ; +visit_type_str (v, param, &p->tls_authz->u.s, &err); +break ;case MIGRATION_PARAMETER_MAX_BANDWIDTH : p->has_max_bandwidth = true;/*
migration/migration.c +8 -0
@@ -721,6 +721,8 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp) params->tls_creds =g_strdup (s->parameters.tls_creds); params->has_tls_hostname = true; params->tls_hostname =g_strdup (s->parameters.tls_hostname); + params->has_tls_authz = true; + params->tls_authz =g_strdup (s->parameters.tls_authz); params->has_max_bandwidth = true; params->max_bandwidth = s->parameters.max_bandwidth; params->has_downtime_limit = true;
@@ -1234,6 +1236,12 @@ static void migrate_params_apply(MigrateSetParameters *params, Error **errp) s->parameters.tls_hostname =g_strdup (params->tls_hostname->u.s); } +if (params->has_tls_authz) { +g_free (s->parameters.tls_authz); +assert (params->tls_authz->type ==QTYPE_QSTRING ); + s->parameters.tls_authz =g_strdup (params->tls_authz->u.s); + } +if (params->has_max_bandwidth) { s->parameters.max_bandwidth = params->max_bandwidth;if (s->to_dst_file) {
migration/tls.c +1 -1
@@ -94,7 +94,7 @@ void migration_tls_channel_process_incoming(MigrationState *s, tioc =qio_channel_tls_new_server ( ioc, creds, -NULL ,/* XXX pass ACL name */ + s->parameters.tls_authz, errp);if (!tioc) {return ;
qapi/migration.json +13 -1
@@ -522,6 +522,12 @@ # hostname must be provided so that the server's x509 # certificate identity can be validated. (Since 2.7) # +# @tls-authz: ID of the 'authz' object subclass that provides access control +# checking of the TLS x509 certificate distinguished name. +# This object is only resolved at time of use, so can be deleted +# and recreated on the fly while the migration server is active. +# If missing, it will default to denying access (Since 4.0) +# # @max-bandwidth: to set maximum speed for migration. maximum speed in # bytes per second. (Since 2.8) #
@@ -563,7 +569,7 @@ 'data': ['compress-level', 'compress-threads', 'decompress-threads', 'compress-wait-thread', 'cpu-throttle-initial', 'cpu-throttle-increment', - 'tls-creds', 'tls-hostname', 'max-bandwidth', + 'tls-creds', 'tls-hostname', 'tls-authz', 'max-bandwidth', 'downtime-limit', 'x-checkpoint-delay', 'block-incremental', 'x-multifd-channels', 'x-multifd-page-count', 'xbzrle-cache-size', 'max-postcopy-bandwidth',
@@ -661,6 +667,7 @@ '*cpu-throttle-increment': 'int', '*tls-creds': 'StrOrNull', '*tls-hostname': 'StrOrNull', + '*tls-authz': 'StrOrNull', '*max-bandwidth': 'int', '*downtime-limit': 'int', '*x-checkpoint-delay': 'int',
@@ -730,6 +737,10 @@ # associated with the migration URI, if any. (Since 2.9) # Note: 2.8 reports this by omitting tls-hostname instead. # +# @tls-authz: ID of the 'authz' object subclass that provides access control +# checking of the TLS x509 certificate distinguished name. (Since +# 4.0) +# # @max-bandwidth: to set maximum speed for migration. maximum speed in # bytes per second. (Since 2.8) #
@@ -777,6 +788,7 @@ '*cpu-throttle-increment': 'uint8', '*tls-creds': 'str', '*tls-hostname': 'str', + '*tls-authz': 'str', '*max-bandwidth': 'size', '*downtime-limit': 'uint64', '*x-checkpoint-delay': 'uint32',
Signature · 1 line
2.20.1
ping - soft freeze is less than a week away & I'd like to see this merged for this release.
Quoted 13 lines · Daniel P. Berrangé
This series provides the migration part of the authorization control series previously posted as:
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg04319.htmlThe core authz framework is now merged & this patch has had positive review. Thus this migration part is ready to go into the migration maintainer's tree, should the maintainer consider them acceptable.
Quoted 12 lines
Daniel P. Berrangé (1):
migration: add support for a "tls-authz" migration parameterhmp.c | 9 +++++++++ migration/migration.c | 8 ++++++++ migration/tls.c | 2 +- qapi/migration.json | 14 +++++++++++++- 4 files changed, 31 insertions(+), 2 deletions(-)Signature · 1 line
2.20.1
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|