Skip to contentSkip to conversation

cxgb4vf: Enter debugging mode if FW is inaccessible

PATCH Applied Arjun Vynipadath 2 participants 2 messages Feb 28, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb4vf: Enter debugging mode if FW is inaccessible

If we are not able to reach firmware, enter debugging mode that will help us to get adapter logs.

---
 drivers/net/ethernet/chelsio/cxgb4vf/adapter.h     |  1 +
 .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c    | 45 +++++++++++++++-------
 2 files changed, 33 insertions(+), 13 deletions(-)
drivers/net/ethernet/chelsio/cxgb4vf/adapter.h +1 -0
index 26f48a14d2f9..86cf68fceceb 100644
@@ -411,6 +411,7 @@ enum { /* adapter flags */
 	USING_MSIX         = (1UL << 2),
 	QUEUES_BOUND       = (1UL << 3),
 	ROOT_NO_RELAXED_ORDERING = (1UL << 4),
+	FW_OK              = (1UL << 5),
 };
 
 /*
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +32 -13

104 lines not on this page · raw message

Signature · 1 line
2.9.5
maintainer Applied
#1 lore raw

From: Arjun Vynipadath <[email protected]>
Date: Thu, 28 Feb 2019 15:33:16 +0530

Quoted 5 lines

If we are not able to reach firmware, enter debugging mode that will help us to get adapter logs.

Applied, however I will say:

drivers/net/ethernet/chelsio/cxgb4vf/adapter.h enum { /* adapter flags */ · line 415

Quoted 6 lines
drivers/net/ethernet/chelsio/cxgb4vf/adapter.h +1 -0
@@ -411,6 +411,7 @@ enum { /* adapter flags */
 	USING_MSIX         = (1UL << 2),
 	QUEUES_BOUND       = (1UL << 3),
 	ROOT_NO_RELAXED_ORDERING = (1UL << 4),
+	FW_OK              = (1UL << 5),
 };

These macros are asking for conflicts in the global namespace and could really use "CXGB4_XXX" prefixes.