Skip to contentSkip to conversation

net: sched: pie: avoid slow division in drop probability decay

PATCH Applied Leslie Monis 2 participants 2 messages Feb 28, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: sched: pie: avoid slow division in drop probability decay

As per RFC 8033, it is sufficient for the drop probability decay factor to have a value of (1 - 1/64) instead of 98%. This avoids the need to do slow division.

---
 net/sched/sch_pie.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/sched/sch_pie.c +2 -1
index f93cfe034c72..1cc0c7b74aa3 100644
@@ -429,7 +429,8 @@ static void calculate_probability(struct Qdisc *sch)
 	 */
 
 	if (qdelay == 0 && qdelay_old == 0 && update_prob)
-		q->vars.prob = 98 * div_u64(q->vars.prob, 100);
+		/* Reduce drop probability to 98.4% */
+		q->vars.prob -= q->vars.prob / 64u;
 
 	q->vars.qdelay = qdelay;
 	q->vars.qlen_old = qlen;
Signature · 1 line
2.17.1