Skip to contentSkip to conversation

arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues

PATCH In review Leonidas P. Papadakos 2 participants 2 messages Feb 28, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues

The rk3328-roc-cc board exhibits tx stability issues with large packets, as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/

A similar patch was made for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx fixes, and I fins that they help with an issue where large transfers would bring the ethernet link down, causing a reset.

---
 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +3 -2
index 99d0d9912950..0e34354b2092 100644
@@ -104,11 +104,12 @@
 	phy-mode = "rgmii";
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmiim1_pins>;
+	snps,force_thresh_dma_mode;
 	snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
 	snps,reset-active-low;
 	snps,reset-delays-us = <0 10000 50000>;
-	tx_delay = <0x25>;
-	rx_delay = <0x11>;
+	tx_delay = <0x24>;
+	rx_delay = <0x18>;
 	status = "okay";
 };
 
Signature · 1 line
2.21.0

A message that is not in the archive (sent off-list or not yet received): 20190228150129.28637-1-papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Hi,

Am Donnerstag, 28. Februar 2019, 16:01:29 CET schrieb Leonidas P. Papadakos:

Quoted 9 lines

The rk3328-roc-cc board exhibits tx stability issues with large packets, as does the rock64 board, which was fixed with this patch
https://patchwork.kernel.org/patch/10178969/

A similar patch was made for the rk3328-roc-cc here
https://patchwork.kernel.org/patch/10804863/
but it doesn't include the tx/rx fixes, and I fins that they help with an issue where large transfers would bring the ethernet link down, causing a reset.

as you can see in the reference patchwork entry, I already applied that patch and it will be part of kernel 5.1.

So please base you works on top of that state (like the linux-next for convenience) - i.e. your patch should not again try to add the thres_dma_mode property, as it is now already present in the devicetree.

Thanks
Heiko

Quoted 25 lines
---
 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +3 -2
index 99d0d9912950..0e34354b2092 100644
@@ -104,11 +104,12 @@
 	phy-mode = "rgmii";
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmiim1_pins>;
+	snps,force_thresh_dma_mode;
 	snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
 	snps,reset-active-low;
 	snps,reset-delays-us = <0 10000 50000>;
-	tx_delay = <0x25>;
-	rx_delay = <0x11>;
+	tx_delay = <0x24>;
+	rx_delay = <0x18>;
 	status = "okay";
 };