Skip to contentSkip to conversation

nvme: Don't warn on block content change effects

PATCH New Keith Busch 3 participants 3 messages Feb 28, 2019 – Mar 8, 2019 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: Don't warn on block content change effects

A write or flush IO passthrough command is expected to change the logical block content, so don't warn on these as no additional handling is necessary.

Signed-off-by Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index 07bf2bff3a76..e1d3e9c41d84 100644
@@ -1250,7 +1250,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
 	if (ns) {
 		if (ctrl->effects)
 			effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
-		if (effects & ~NVME_CMD_EFFECTS_CSUPP)
+		if (effects & ~(NVME_CMD_EFFECTS_CSUPP|NVME_CMD_EFFECTS_LBCC))
 			dev_warn(ctrl->device,
 				 "IO command:%02x has unhandled effects:%08x\n",
 				 opcode, effects);
Signature · 1 line
2.14.4
maintainer
#1 lore raw

PATCH 1/1 nvme: Don't warn on block content change effects

Reviewed-by Sagi Grimberg <sagi at grimberg.me>