Skip to contentSkip to conversation

A quesiton about commit 3a63f70bf4c3

PATCH Baoquan He 2 participants 3 messages Mar 1, 2019 – Mar 4, 2019 x86

lore
Share & tools
lore

Baoquan He

author
#0 lore raw

Hi Chao,

I am back porting this commit to our distrols from tip. 3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params

Findind out those SRAT handling related declarations are out of BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose?

Saw "misc.h" is included in several places, shouldn't be changed like below? Please correct me if I was wrong.

Thanks
Baoquan

arch/x86/boot/compressed/misc.h +1 -2
index fd13655..252091b 100644
@@ -120,8 +120,6 @@ static inline void console_init(void)
 
 void set_sev_encryption_mask(void);
 
-#endif
-
 /* acpi.c */
 #ifdef CONFIG_ACPI
 acpi_physical_address get_rsdp_addr(void);
@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
 #else
 static inline int count_immovable_mem_regions(void) { return 0; }
 #endif
+#endif
#1 lore raw
Quoted 2 lines · Baoquan He

Hi Chao,

Hi Baoquan,

Sorry for late reply, I was away from keyboard last Friday. Your change looks good, I think you can format it as a real PATCH.

Quoted 2 lines

I am back porting this commit to our distrols from tip.

Thanks for your effort.

Thanks,
Chao Fan

Quoted 33 lines

3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params

Findind out those SRAT handling related declarations are out of BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose?

Saw "misc.h" is included in several places, shouldn't be changed like below? Please correct me if I was wrong.

Thanks
Baoquan

arch/x86/boot/compressed/misc.h +1 -2
index fd13655..252091b 100644
@@ -120,8 +120,6 @@ static inline void console_init(void)
 
 void set_sev_encryption_mask(void);
 
-#endif
-
 /* acpi.c */
 #ifdef CONFIG_ACPI
 acpi_physical_address get_rsdp_addr(void);
@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
 #else
 static inline int count_immovable_mem_regions(void) { return 0; }
 #endif
+#endif
author
#2 lore raw
Quoted 7 lines · Chao Fan
Quoted 2 lines · Baoquan He

Hi Chao,

Hi Baoquan,

Sorry for late reply, I was away from keyboard last Friday. Your change looks good, I think you can format it as a real PATCH.

Thx, sent.