Skip to contentSkip to conversation

habanalabs: use do_div for 64-bit divisions

PATCH New Oded Gabbay 1 participant 1 message Mar 1, 2019 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: use do_div for 64-bit divisions

This patch fix compilation error in 32-bit ARM architecture regarding division of 2 64-bit variables.

Use the kernel do_div() macro, which is implemented per architecture, for doing these divisions instead of using the / operator.

---
 drivers/misc/habanalabs/mmu.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/misc/habanalabs/mmu.c +6 -6
index ce404e6cc9a9..2f2e99cb2743 100644
@@ -261,9 +261,9 @@ int hl_mmu_ctx_init(struct hl_ctx *ctx)
 			!hdev->dram_default_page_mapping)
 		return 0;
 
-	num_of_hop3 = (prop->dram_size_for_default_page_mapping /
-			prop->dram_page_size) /
-			PTE_ENTRIES_IN_HOP;
+	num_of_hop3 = prop->dram_size_for_default_page_mapping;
+	do_div(num_of_hop3, prop->dram_page_size);
+	do_div(num_of_hop3, PTE_ENTRIES_IN_HOP);
 
 	/* add hop1 and hop2 */
 	total_hops = num_of_hop3 + 2;
@@ -378,9 +378,9 @@ void hl_mmu_ctx_fini(struct hl_ctx *ctx)
 	if (hdev->dram_supports_virtual_memory &&
 			hdev->dram_default_page_mapping) {
 
-		num_of_hop3 = (prop->dram_size_for_default_page_mapping /
-				prop->dram_page_size) /
-				PTE_ENTRIES_IN_HOP;
+		num_of_hop3 = prop->dram_size_for_default_page_mapping;
+		do_div(num_of_hop3, prop->dram_page_size);
+		do_div(num_of_hop3, PTE_ENTRIES_IN_HOP);
 
 		/* add hop1 and hop2 */
 		total_hops = num_of_hop3 + 2;
Signature · 1 line
2.17.1