Skip to contentSkip to conversation

Staging: wlan-ng: Fix parenthesis alignment

PATCH In review Daniela Mormocea 3 participants 3 messages Mar 4, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: wlan-ng: Fix parenthesis alignment

Fix alignment issue with parenthesis.

---
 drivers/staging/wlan-ng/cfg80211.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/wlan-ng/cfg80211.c +3 -6
index 8a862f7..7c4e8f1f8 100644
@@ -332,8 +332,7 @@ static int prism2_scan(struct wiphy *wiphy,
 		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
 		i++)
 		msg1.channellist.data.data[i] =
-			ieee80211_frequency_to_channel(
-				request->channels[i]->center_freq);
+			ieee80211_frequency_to_channel(request->channels[i]->center_freq);
 	msg1.channellist.data.len = request->n_channels;
 
 	msg1.maxchanneltime.data = 250;
@@ -372,11 +371,9 @@ static int prism2_scan(struct wiphy *wiphy,
 			(const u8 *)&msg2.bssid.data.data,
 			msg2.timestamp.data, msg2.capinfo.data,
 			msg2.beaconperiod.data,
-			ie_buf,
-			ie_len,
+			ie_buf, ie_len,
 			(msg2.signal.data - 65536) * 100, /* Conversion to signed type */
-			GFP_KERNEL
-		);
+			GFP_KERNEL);
 
 		if (!bss) {
 			err = -ENOMEM;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Daniela Mormocea

Fix alignment issue with parenthesis.

---
 drivers/staging/wlan-ng/cfg80211.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

What changed from v1?

That always belongs below the --- line.

drivers/staging/wlan-ng/cfg80211.c static int prism2_scan(struct wiphy *wiphy, · line 335

Quoted 12 lines
drivers/staging/wlan-ng/cfg80211.c +1 -2
index 8a862f7..7c4e8f1f8 100644
@@ -332,8 +332,7 @@ static int prism2_scan(struct wiphy *wiphy,
 		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
 		i++)
 		msg1.channellist.data.data[i] =
-			ieee80211_frequency_to_channel(
-				request->channels[i]->center_freq);
+			ieee80211_frequency_to_channel(request->channels[i]->center_freq);

You just violated another coding style rule by doing this :(

The original code is fine, leave it as-is please.

drivers/staging/wlan-ng/cfg80211.c static int prism2_scan(struct wiphy *wiphy, · line 374

Quoted 10 lines
drivers/staging/wlan-ng/cfg80211.c +1 -2
 	msg1.channellist.data.len = request->n_channels;
 
 	msg1.maxchanneltime.data = 250;
@@ -372,11 +371,9 @@ static int prism2_scan(struct wiphy *wiphy,
 			(const u8 *)&msg2.bssid.data.data,
 			msg2.timestamp.data, msg2.capinfo.data,
 			msg2.beaconperiod.data,
-			ie_buf,
-			ie_len,
+			ie_buf, ie_len,

This change has nothing to do with the subject :(

thanks,

greg k-h

maintainer
#2 lore raw
In reply to Daniela Mormocea
Quoted 6 lines · Daniela Mormocea

Fix alignment issue with parenthesis.

---
 drivers/staging/wlan-ng/cfg80211.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

What changed from v1?

That always belongs below the --- line.

drivers/staging/wlan-ng/cfg80211.c static int prism2_scan(struct wiphy *wiphy, · line 335

Quoted 12 lines
drivers/staging/wlan-ng/cfg80211.c +1 -2
index 8a862f7..7c4e8f1f8 100644
@@ -332,8 +332,7 @@ static int prism2_scan(struct wiphy *wiphy,
 		(i < request->n_channels) && i < ARRAY_SIZE(prism2_channels);
 		i++)
 		msg1.channellist.data.data[i] =
-			ieee80211_frequency_to_channel(
-				request->channels[i]->center_freq);
+			ieee80211_frequency_to_channel(request->channels[i]->center_freq);

You just violated another coding style rule by doing this :(

The original code is fine, leave it as-is please.

drivers/staging/wlan-ng/cfg80211.c static int prism2_scan(struct wiphy *wiphy, · line 374

Quoted 10 lines
drivers/staging/wlan-ng/cfg80211.c +1 -2
 	msg1.channellist.data.len = request->n_channels;
 
 	msg1.maxchanneltime.data = 250;
@@ -372,11 +371,9 @@ static int prism2_scan(struct wiphy *wiphy,
 			(const u8 *)&msg2.bssid.data.data,
 			msg2.timestamp.data, msg2.capinfo.data,
 			msg2.beaconperiod.data,
-			ie_buf,
-			ie_len,
+			ie_buf, ie_len,

This change has nothing to do with the subject :(

thanks,

greg k-h