Staging: fbtft: Lines over 80 characters
Subsystems (2)
PATCH 1/1 Staging: fbtft: Lines over 80 characters
Fix lines with over 80 characters
--- drivers/staging/fbtft/flexfb.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/staging/fbtft/flexfb.c +7 -2
@@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device *sdev,break ;case 9 :if (regwidth ==16 ) { -dev_err (dev,"argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n" , regwidth, buswidth); +dev_err (dev, + "argument 'regwidth': %d is not + supported with buswidth=%d and SPI.\n", + regwidth, buswidth);return -EINVAL ; } par->fbtftops.write_register = fbtft_write_reg8_bus9;
@@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device *sdev, par->fbtftops.write_vmem = fbtft_write_vmem16_bus16;break ;default : -dev_err (dev,"argument 'buswidth': %d is not supported with parallel.\n" , buswidth); +dev_err (dev, +"argument 'buswidth': %d is not supported with parallel.\n" , + buswidth);return -EINVAL ; } }
Signature · 1 line
2.7.4
Quoted 12 lines · Daniela Mormocea
Fix lines with over 80 characters
Signed-off-by Daniela Mormocea <[email protected]>--- drivers/staging/fbtft/flexfb.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/staging/fbtft/flexfb.c +0
-0
drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device *sdev, · line 676
Quoted 7 lines
drivers/staging/fbtft/flexfb.c +3
-1@@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device *sdev,break ;case 9 :if (regwidth ==16 ) { -dev_err (dev,"argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n" , regwidth, buswidth); + dev_err(dev, + "argument 'regwidth': %d is not + supported with buswidth=%d and SPI.\n",
Don't break the string in this way. Strings are allowed to drift over 80 characters, so that it is possible to grep for the string that one sees at runtime.
julia
Quoted 25 lines
drivers/staging/fbtft/flexfb.c +4
-2+ regwidth, buswidth);return -EINVAL ; } par->fbtftops.write_register = fbtft_write_reg8_bus9;@@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device *sdev, par->fbtftops.write_vmem = fbtft_write_vmem16_bus16;break ;default : -dev_err (dev,"argument 'buswidth': %d is not supported with parallel.\n" , buswidth); +dev_err (dev, +"argument 'buswidth': %d is not supported with parallel.\n" , + buswidth);return -EINVAL ; } } --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304210909.GA4408%40pthm.
For more options, visit https://groups.google.com/d/optout.
ok, I understand, thank you
should I correct the string issue and mail this patch again?
Quoted 71 lines · Julia Lawall
Review
Quoted 8 lines · Daniela Mormocea
Fix lines with over 80 characters
Signed-off-by Daniela Mormocea <[email protected] <javascript:>>---
drivers/staging/fbtft/flexfb.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/staging/fbtft/flexfb.cdrivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device
Quoted 4 lines
index c5fa591..0759d93 100644
drivers/staging/fbtft/flexfb.c +0
-0@@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device*sdev,
drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device *sdev,
Quoted 4 lines
drivers/staging/fbtft/flexfb.c +0
-1break ;case 9 :if (regwidth ==16 ) { - dev_err(dev, "argument 'regwidth': %dis not supported with buswidth=%d and SPI.\n", regwidth, buswidth);
drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device *sdev,
Quoted 3 lines
drivers/staging/fbtft/flexfb.c +3
-0+ dev_err(dev, + "argument 'regwidth': %d is not + supported with buswidth=%d andSPI.\n",
Don't break the string in this way. Strings are allowed to drift over 80 characters, so that it is possible to grep for the string that one sees at runtime.
julia
drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device *sdev,
Quoted 4 lines
drivers/staging/fbtft/flexfb.c +1
-0+ regwidth, buswidth);return -EINVAL ; } par->fbtftops.write_register =
fbtft_write_reg8_bus9;drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device
Quoted 1 line
drivers/staging/fbtft/flexfb.c +0
-0@@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device*sdev,
drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device · line 721
Quoted 1 line
drivers/staging/fbtft/flexfb.c +0
-0par->fbtftops.write_vmem =
fbtft_write_vmem16_bus16;drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device *sdev,
Quoted 3 lines
drivers/staging/fbtft/flexfb.c +0
-1break ;default : - dev_err(dev, "argument 'buswidth': %d is notsupported with parallel.\n", buswidth);
drivers/staging/fbtft/flexfb.c static int flexfb_probe_common(struct spi_device · line 725
Quoted 2 lines
drivers/staging/fbtft/flexfb.c +2
-0+ dev_err(dev, + "argument 'buswidth': %d is notsupported with parallel.\n",
Quoted 9 lines
drivers/staging/fbtft/flexfb.c +1
-0+ buswidth);return -EINVAL ; } }Signature · 4 lines
2.7.4 -- You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20190304210909.GA4408%40pthm.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 2 lines · Dana Mormocea
ok, I understand, thank you
should I correct the string issue and mail this patch again?
To my recollection, the rest looked ok. So you can fix it up and send it again. Please don't top post. You see how I have put my response under your text that I am responding to.
julia
Quoted 86 lines · Julia Lawall
On Mon, 4 Mar 2019, Daniela Mormocea wrote: > Fix lines with over 80 characters > > Signed-off-by: Daniela Mormocea <[email protected]> > --- > drivers/staging/fbtft/flexfb.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c > index c5fa591..0759d93 100644 > --- a/drivers/staging/fbtft/flexfb.c > +++ b/drivers/staging/fbtft/flexfb.c > @@ -671,7 +671,10 @@ static int flexfb_probe_common(struct spi_device *sdev, > break; > case 9: > if (regwidth == 16) { > - dev_err(dev, "argument 'regwidth': %d is not supported with buswidth=%d and SPI.\n", regwidth, buswidth); > + dev_err(dev, > + "argument 'regwidth': %d is not > + supported with buswidth=%d and SPI.\n", Don't break the string in this way. Strings are allowed to drift over 80 characters, so that it is possible to grep for the string that one sees at runtime. julia > + regwidth, buswidth); > return -EINVAL; > } > par->fbtftops.write_register = fbtft_write_reg8_bus9; > @@ -718,7 +721,9 @@ static int flexfb_probe_common(struct spi_device *sdev, > par->fbtftops.write_vmem = fbtft_write_vmem16_bus16; > break; > default: > - dev_err(dev, "argument 'buswidth': %d is not supported with parallel.\n", buswidth); > + dev_err(dev, > + "argument 'buswidth': %d is not supported with parallel.\n", > + buswidth); > return -EINVAL; > } > } > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20190304210909.GA4408%40 pthm. > For more options, visit https://groups.google.com/d/optout. >--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/ba227e82-6a25-4767-8358- 26f2a1a17f13%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.