Skip to contentSkip to conversation

exec: Fix mem leak in kernel_read_file

PATCH In review Thibaut Sautereau 2 participants 4 messages Mar 4, 2019 – Mar 8, 2019 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 exec: Fix mem leak in kernel_read_file

Commit f612acfae86af7ecad754ae6a46019be9da05b8e upstream ("exec: Fix mem leak in kernel_read_file"), addressing CVE-2019-8980, should be applied to 4.20, 4.19, 4.14 and 4.9 stable kernels.

Thanks,

Signature · 2 lines
Thibaut Sautereau
CLIP OS developer
maintainer
#1 lore raw
Quoted 3 lines · Thibaut Sautereau

Commit f612acfae86af7ecad754ae6a46019be9da05b8e upstream ("exec: Fix mem leak in kernel_read_file"), addressing CVE-2019-8980, should be applied to 4.20, 4.19, 4.14 and 4.9 stable kernels.

Any reason you didn't cc: the authors of that patch?

And as it _just_ went into Linus's tree today, give us a few weeks to get it backported...

Also, it's just a "normal" syzbot fix, for a very rare case, why is this a CVE?

thanks,

greg k-h

#2 lore raw
Quoted 6 lines · Greg KH
Quoted 3 lines · Thibaut Sautereau

Commit f612acfae86af7ecad754ae6a46019be9da05b8e upstream ("exec: Fix mem leak in kernel_read_file"), addressing CVE-2019-8980, should be applied to 4.20, 4.19, 4.14 and 4.9 stable kernels.

Any reason you didn't cc: the authors of that patch?

No, I just forgot, sorry for that.

Quoted 5 lines

And as it _just_ went into Linus's tree today, give us a few weeks to get it backported...

Also, it's just a "normal" syzbot fix, for a very rare case, why is this a CVE?

I don't know (I'm not the one who requested a CVE), but I saw that this patch had been backported in Arch Linux's kernels to address CVE-2019-8980 [1] and that [email protected] hadn't been put in Cc:.

As the fix was already waiting in a pull-request [2] from Al Viro, I thought it was too late to notice the author about Ccing stable, therefore I followed option 2 of Documentation/process/stable-kernel-rules.rst to ensure it would not fall through the cracks.

If that was the wrong way to do it, please tell me what I should have done in this case.

Thanks,

[1] https://nvd.nist.gov/vuln/detail/CVE-2019-8980
[2] https://lkml.org/lkml/2019/3/2/230

Signature · 1 line
Thibaut Sautereau
maintainer
#3 lore raw
Quoted 20 lines · Thibaut Sautereau
Quoted 6 lines · Greg KH
Quoted 3 lines · Thibaut Sautereau

Commit f612acfae86af7ecad754ae6a46019be9da05b8e upstream ("exec: Fix mem leak in kernel_read_file"), addressing CVE-2019-8980, should be applied to 4.20, 4.19, 4.14 and 4.9 stable kernels.

Any reason you didn't cc: the authors of that patch?

No, I just forgot, sorry for that.

Quoted 5 lines

And as it _just_ went into Linus's tree today, give us a few weeks to get it backported...

Also, it's just a "normal" syzbot fix, for a very rare case, why is this a CVE?

I don't know (I'm not the one who requested a CVE), but I saw that this patch had been backported in Arch Linux's kernels to address CVE-2019-8980 [1] and that [email protected] hadn't been put in Cc:.

Quoted 8 lines

As the fix was already waiting in a pull-request [2] from Al Viro, I thought it was too late to notice the author about Ccing stable, therefore I followed option 2 of Documentation/process/stable-kernel-rules.rst to ensure it would not fall through the cracks.

If that was the wrong way to do it, please tell me what I should have done in this case.

No, this is fine, just next time you should cc: the developers as well.

Also, this needs to go to 5.0.y, now queued up.

greg k-h