Skip to contentSkip to conversation

mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk

PATCH Superseded Axel Lin 2 participants 2 messages Mar 6, 2019 – Mar 7, 2019 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk

Since devm_regmap_init_mmio_clk can fail, add return value checking.

---
 drivers/mfd/hi655x-pmic.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mfd/hi655x-pmic.c +2 -0
index 96c07fa1802a..6693f74aa6ab 100644
@@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
 
 	pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
 						 &hi655x_regmap_config);
+	if (IS_ERR(pmic->regmap))
+		return PTR_ERR(pmic->regmap);
 
 	regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
 	if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
Signature · 1 line
2.17.1
#1 lore raw

Thanks

Quoted 21 lines · Axel Lin

Since devm_regmap_init_mmio_clk can fail, add return value checking.

---
 drivers/mfd/hi655x-pmic.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mfd/hi655x-pmic.c +2 -0
index 96c07fa1802a..6693f74aa6ab 100644
@@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
 
 	pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
 						 &hi655x_regmap_config);
+	if (IS_ERR(pmic->regmap))
+		return PTR_ERR(pmic->regmap);
 
 	regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
 	if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
Signature · 2 lines
Cheers,
- Feng