xen, cpu_hotplug: Prevent an out of bounds access
Subsystems (2)
PATCH 1/1 xen, cpu_hotplug: Prevent an out of bounds access
The "cpu" variable comes from the sscanf() so Smatch marks it as untrusted data. We can't pass a higher value than "nr_cpu_ids" to cpu_possible() or it results in an out of bounds access.
Fixes d68d82afd4c8 ("xen: implement CPU hotplugging")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/xen/cpu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/cpu_hotplug.c +1 -1
@@ -54,7 +54,7 @@ static int vcpu_online(unsigned int cpu) }static void vcpu_hotplug (unsigned int cpu) { -if (!cpu_possible (cpu)) +if (cpu >= nr_cpu_ids || !cpu_possible (cpu))return ;switch (vcpu_online (cpu)) {
Signature · 1 line
2.17.1
Quoted 6 lines · Dan Carpenter
The "cpu" variable comes from the
sscanf()so Smatch marks it as untrusted data. We can't pass a higher value than "nr_cpu_ids" tocpu_possible()or it results in an out of bounds access.Fixes d68d82afd4c8 ("xen: implement CPU hotplugging")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Juergen Gross <[email protected]>
Juergen
Quoted 6 lines · Dan Carpenter
The "cpu" variable comes from the
sscanf()so Smatch marks it as untrusted data. We can't pass a higher value than "nr_cpu_ids" tocpu_possible()or it results in an out of bounds access.Fixes d68d82afd4c8 ("xen: implement CPU hotplugging")Signed-off-by Dan Carpenter <[email protected]>
Pushed to xen/tip.git for-linus-5.1a
Juergen