Skip to contentSkip to conversation

dma-mapping: work around clang bug

PATCH Superseded Arnd Bergmann 2 participants 3 messages Mar 7, 2019 DMA mapping helpers

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma-mapping: work around clang bug

Clang has a rather annoying behavior of checking for integer arithmetic problems in code paths that are discarded by gcc before that perfoms the same checks.

For DMA_BIT_MASK(64), this leads to a warning despite the result of the macro being completely sensible:

arch/arm/plat-iop/adma.c:146:24: error: shift count >= width of type [-Werror,-Wshift-count-overflow]

                .coherent_dma_mask = DMA_BIT_MASK(64),

The best workaround I could come up with is to shift the value twice, which makes the macro way less readable but always has the same result.

---
 include/linux/dma-mapping.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/dma-mapping.h +2 -1
index 75e60be91e5f..380d3a95d02e 100644
@@ -138,7 +138,8 @@ struct dma_map_ops {
 extern const struct dma_map_ops dma_virt_ops;
 extern const struct dma_map_ops dma_dummy_ops;
 
-#define DMA_BIT_MASK(n)	(((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
+/* double shift to work around https://bugs.llvm.org/show_bug.cgi?id=38789 */
+#define DMA_BIT_MASK(n)	(((n) == 64) ? ~0ULL : (((1ULL<<((n)-1))-1) << 1))
 
 #define DMA_MASK_NONE	0x0ULL
 
Signature · 1 line
2.20.0
#1 lore raw

Hi Arnd,

Quoted 25 lines · Arnd Bergmann

Clang has a rather annoying behavior of checking for integer arithmetic problems in code paths that are discarded by gcc before that perfoms the same checks.

For DMA_BIT_MASK(64), this leads to a warning despite the result of the macro being completely sensible:

arch/arm/plat-iop/adma.c:146:24: error: shift count >= width of type [-Werror,-Wshift-count-overflow]

                .coherent_dma_mask = DMA_BIT_MASK(64),

The best workaround I could come up with is to shift the value twice, which makes the macro way less readable but always has the same result.

---
 include/linux/dma-mapping.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/dma-mapping.h +0 -0
index 75e60be91e5f..380d3a95d02e 100644

include/linux/dma-mapping.h struct dma_map_ops { · line 142

Quoted 6 lines
include/linux/dma-mapping.h +2 -1
@@ -138,7 +138,8 @@ struct dma_map_ops {
 extern const struct dma_map_ops dma_virt_ops;
 extern const struct dma_map_ops dma_dummy_ops;
 
-#define DMA_BIT_MASK(n)        (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
+/* double shift to work around https://bugs.llvm.org/show_bug.cgi?id=38789 */
+#define DMA_BIT_MASK(n)        (((n) == 64) ? ~0ULL : (((1ULL<<((n)-1))-1) << 1))

The second "-1" should be done on the final result, not on the intermediate value.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#2 lore raw
Quoted 29 lines · Geert Uytterhoeven
Quoted 28 lines · Arnd Bergmann

Clang has a rather annoying behavior of checking for integer arithmetic problems in code paths that are discarded by gcc before that perfoms the same checks.

For DMA_BIT_MASK(64), this leads to a warning despite the result of the macro being completely sensible:

arch/arm/plat-iop/adma.c:146:24: error: shift count >= width of type [-Werror,-Wshift-count-overflow]

                .coherent_dma_mask = DMA_BIT_MASK(64),

The best workaround I could come up with is to shift the value twice, which makes the macro way less readable but always has the same result.

---
 include/linux/dma-mapping.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/dma-mapping.h +0 -0
index 75e60be91e5f..380d3a95d02e 100644
@@ -138,7 +138,8 @@ struct dma_map_ops {
 extern const struct dma_map_ops dma_virt_ops;
 extern const struct dma_map_ops dma_dummy_ops;
 
Quoted 6 lines

include/linux/dma-mapping.h struct dma_map_ops { · line 142

Quoted 3 lines
include/linux/dma-mapping.h +2 -1
-#define DMA_BIT_MASK(n)        (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
+/* double shift to work around https://bugs.llvm.org/show_bug.cgi?id=38789 */
+#define DMA_BIT_MASK(n)        (((n) == 64) ? ~0ULL : (((1ULL<<((n)-1))-1) << 1))

The second "-1" should be done on the final result, not on the intermediate value.

Ah, of course. I'll send an update patch in a bit, sorry about this.

Arnd